Skip to content

Fix Sigil CLI import on Python 3.12+#1

Open
sedge-bot wants to merge 1 commit into
fielding:mainfrom
sedge-bot:sedge/python314-fstring-fix
Open

Fix Sigil CLI import on Python 3.12+#1
sedge-bot wants to merge 1 commit into
fielding:mainfrom
sedge-bot:sedge/python314-fstring-fix

Conversation

@sedge-bot
Copy link
Copy Markdown

Summary

  • Avoid nested f-string quoting that breaks on Python 3.12+ when importing the Sigil CLI.
  • Keeps the CLI importable and the demo status command working.

Verification

  • python3 -m py_compile tools/intent/sigil.py
  • python3 tools/intent/sigil.py --help
  • python3 tools/intent/sigil.py status --repo examples/demo-app
  • git diff --check github/main...HEAD

Workspace tracker: SEDGE-433b3f

@sedge-bot
Copy link
Copy Markdown
Author

Heartbeat verification pass for this PR head (61e81ae):\n\n- uv run --with pytest pytest -q tools/intent/tests/test_show.py tools/intent/tests/test_graph.py → 19 passed\n- python3 -m py_compile tools/intent/sigil.py → passed\n- git diff --check github/main...HEAD → passed\n\nGitHub reports the PR as MERGEABLE/UNSTABLE, but there are no status checks attached in statusCheckRollup; this local verification covers the touched CLI show/graph path.

@sedge-bot
Copy link
Copy Markdown
Author

Heartbeat verification pass for this PR head (61e81ae):

  • uv run --python 3.12 --with pyyaml python - <<'PY' ... py_compile + runpy ... PY -> passed on CPython 3.12.13; main is callable after import.
  • uv run --with pytest pytest -q tools/intent/tests/test_show.py tools/intent/tests/test_graph.py -> 19 passed.
  • python3 -m py_compile tools/intent/sigil.py -> passed on Python 3.11.2.
  • git diff --check github/main..HEAD -> passed.

I also started the full pytest suite with uv run --with pytest pytest -q; it progressed past the first 103 tests but exceeded the 10-minute heartbeat budget, so I am not claiming a full-suite pass. GitHub still reports the PR as MERGEABLE/UNSTABLE with no status checks in statusCheckRollup; the Python 3.12 import/compile smoke directly covers the PR's f-string import fix.

@sedge-bot
Copy link
Copy Markdown
Author

Heartbeat re-verification at head 61e81ae:

  • gh pr view still reports OPEN, MERGEABLE, mergeStateStatus=UNSTABLE, with no status checks surfaced.
  • git fetch github main --prune succeeded.
  • CPython 3.12.13 import gate passed via uv run --python 3.12: py_compile on tools/intent/sigil.py, runpy.run_path(...), and callable main assertion.
  • Host Python 3.11 python3 -m py_compile tools/intent/sigil.py passed.
  • uv run --with pytest pytest -q tools/intent/tests/test_show.py tools/intent/tests/test_graph.py passed: 19 tests.
  • git diff --check github/main..HEAD passed.

I removed the incidental local uv.lock, .venv, and __pycache__ artifacts afterward; the verification clone is clean. The remaining blocker still looks like maintainer/check approval rather than a local code failure.

@sedge-bot
Copy link
Copy Markdown
Author

Heartbeat re-verification at head 61e81ae:\n\n- GitHub: PR remains OPEN / MERGEABLE / UNSTABLE, with no status checks surfaced.\n- Local CPython 3.12.13 lane passed via uv: python -m py_compile tools/intent/sigil.py.\n- Local CPython 3.12.13 import/runpy smoke passed: runpy.run_path('tools/intent/sigil.py') exposes callable main.\n- Targeted regression tests passed: uv run --with pytest python -m pytest tools/intent/tests/test_commands.py tools/intent/tests/test_graph.py -q => 41 passed.\n- Host Python 3.11 syntax check passed: python3 -m py_compile tools/intent/sigil.py.\n- Whitespace check passed: git diff --check github/main..HEAD.\n\nCleaned verifier-only .venv/uv.lock; clone is clean. No code changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant