Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: default values for Client's lifetimes are misleading #213

Open
frankie567 opened this issue Jun 7, 2023 · 0 comments
Open

OpenAPI: default values for Client's lifetimes are misleading #213

frankie567 opened this issue Jun 7, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers polar

Comments

@frankie567
Copy link
Member

frankie567 commented Jun 7, 2023

Following #211 and #194, we found out that, by default, OpenAPI sets default values for authorization_code_lifetime_seconds, access_id_token_lifetime_seconds and refresh_token_lifetime_seconds to 0.

This is misleading because, as we've seen, developers can copy/paste the whole example payload and inadvertently set the token lifetime to zero.

We should tweak the Pydantic schema so OpenAPI shows more sensible values.

BTW, maybe we should reconsider the minimum validation for those values, which is currently 0.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@frankie567 frankie567 added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers polar
Projects
None yet
Development

No branches or pull requests

1 participant