Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overlay wrapper for waves and its ripple effect #178

Open
fians opened this issue Oct 24, 2017 · 2 comments
Open

Use overlay wrapper for waves and its ripple effect #178

fians opened this issue Oct 24, 2017 · 2 comments
Milestone

Comments

@fians
Copy link
Owner

fians commented Oct 24, 2017

I think it would be good if Waves create an overlay wrapper element inside an actual element and put all the ripple effect child there.

Instead doing this:

<a href="#" class="waves">
  This is button
  <i class="ripple"></i>
  <i class="ripple"></i>
  <i class="ripple"></i>
</a>

Waves should doing like this:

<a href="#" class="waves">
  This is button
  <span class="wrapper">
    <i class="ripple"></i>
    <i class="ripple"></i>
    <i class="ripple"></i>
  </span>
</a>
@fians fians added this to the v0.8.0 milestone Oct 24, 2017
@fians
Copy link
Owner Author

fians commented Oct 24, 2017

I think this will fix #147, #132 and I hope it also fix bootstrap issue on #144

@miguelcobain
Copy link

This would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants