Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking build from typescript 4.7.2 on #1181

Closed
jonasvoelcker opened this issue Aug 4, 2022 · 1 comment
Closed

Breaking build from typescript 4.7.2 on #1181

jonasvoelcker opened this issue Aug 4, 2022 · 1 comment
Assignees

Comments

@jonasvoelcker
Copy link

Hey there,

first of all thanks a lot for your awesome project, we are using it successfully for our client generation :)

As we are using renovatebot for automatic version updates for some days now, it bumped typescript to the version 4.7.4 and suddenly our build broke:

TS2564: Property '[Symbol.toStringTag]' has no initializer and is not definitely assigned in the constructor.
22 |
23 | export class CancelablePromise implements Promise {
> 24 | readonly [Symbol.toStringTag]: string;
| ^^^^^^^^^^^^^^^^^^^^
25 |
26 | private _isResolved: boolean;
27 | private _isRejected: boolean;

After a short google-search I've found this page stating, that a simple exclamationmark comes to the rescue for avoiding (or maybe fulfilling) the stricter checks on constructors: microsoft/TypeScript-Vue-Starter#36

So this means after changing the line to readonly [Symbol.toStringTag]!: string;, we were back to green.

Could you please consider this change for the next version?

Best Regards
Jonas

@jonasvoelcker
Copy link
Author

Oh, I guess there had someone been faster :D
9e9c592

I'll just wait for the next release, thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants