Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifiying static coordinates #52

Closed
wants to merge 4 commits into from
Closed

Allow specifiying static coordinates #52

wants to merge 4 commits into from

Conversation

guidezpl
Copy link

@guidezpl guidezpl commented Jul 4, 2019

Fixes #49

Also fixes a bug where the Darksky api gets recalled 5 times even if successful.

Note I didn't do the zip or change the top-level README.

joshbuhler
joshbuhler approved these changes Oct 8, 2019
View reviewed changes
Copy link

@joshbuhler joshbuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I applied these changes to my local copy of this widget, and DarkSky static locations are now working.

@guidezpl
Copy link
Author

@felixhageloh Can you please review?

@guidezpl guidezpl closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbuhler joshbuhler joshbuhler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static location not working with darksky
2 participants
@guidezpl @joshbuhler