Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change: equals removed in v2.0.6 #187

Closed
LukasMirbt opened this issue Nov 21, 2024 · 5 comments
Closed

breaking change: equals removed in v2.0.6 #187

LukasMirbt opened this issue Nov 21, 2024 · 5 comments
Assignees

Comments

@LukasMirbt
Copy link

LukasMirbt commented Nov 21, 2024

Describe the bug
The public equals function was removed from equatable_utils.dart in v2.0.6 causing dependent code to break.

Additional context
In my case, I use the dart-dio OpenAPI generator with equalityCheckMethod: equatable which broke in v2.0.6.

@felangel
Copy link
Owner

Sorry about that! I’ll get a fix out shortly — I was under the impression that the utilities were not publicly exported.

@felangel felangel self-assigned this Nov 21, 2024
@felangel
Copy link
Owner

@LukasMirbt I just took a look and it doesn't look like equals or any of the equatable_utils were publicly exported in v2.0.5. They open api generator was directly importing a private method straight from the src directory which is never safe :(

@LukasMirbt
Copy link
Author

Hm, yea you're right. It imports 'package:equatable/src/equatable_utils.dart'; which one could argue makes it not a breaking change.

Is it still worth adding it back considering how widely used the package is and that it breaks some use cases (even if the file is inappropriately imported)?

@felangel
Copy link
Owner

Even though it's technically not a breaking change I re-introduced equals in #190

@felangel
Copy link
Owner

This should be fixed in v2.0.7 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants