ci: allow the installation of greenboot rpm packages from compose - #178
Open
mcattamoredhat wants to merge 2 commits into
Open
ci: allow the installation of greenboot rpm packages from compose#178mcattamoredhat wants to merge 2 commits into
mcattamoredhat wants to merge 2 commits into
Conversation
knecasov
reviewed
Apr 27, 2026
knecasov
reviewed
Apr 27, 2026
knecasov
reviewed
Apr 27, 2026
knecasov
reviewed
Apr 27, 2026
knecasov
reviewed
Apr 27, 2026
knecasov
reviewed
Apr 27, 2026
knecasov
left a comment
There was a problem hiding this comment.
I added a few comments.
Have you considered extracting the shared parts of the code (for example, an RPM download logic) into a common helper, please? The same block is repeated across all three scripts.
knecasov
reviewed
Apr 27, 2026
mcattamoredhat
force-pushed
the
rc-compose-tier1-testing
branch
from
June 4, 2026 11:58
8ef1826 to
6a88fca
Compare
Contributor
Author
Done! |
mcattamoredhat
force-pushed
the
rc-compose-tier1-testing
branch
from
June 11, 2026 10:48
6a88fca to
5986f99
Compare
mcattamoredhat
force-pushed
the
rc-compose-tier1-testing
branch
2 times, most recently
from
July 29, 2026 10:29
47a7b6a to
6402f1a
Compare
… Copr Copr remains the default source for greenboot builds in CI tests. For RHEL 9.8 and RHEL 10.2 targets, when DOWNLOAD_NODE and COMPOSE_ID are both set, download pre-built greenboot RPMs from the compose instead. Assisted-by: Claude (claude-sonnet-5) Signed-off-by: Mario Cattamo <mcattamo@redhat.com>
mcattamoredhat
marked this pull request as draft
July 30, 2026 14:14
Extend the rhel-9.8/rhel-10.2 case blocks to also cover RHEL 9.9 and
RHEL 10.3, following the same Copr-primary / compose-RPM-override
pattern, using ${ARCH} instead of a hardcoded x86_64.
Assisted-by: Claude (claude-sonnet-5)
Signed-off-by: Mario Cattamo <mcattamo@redhat.com>
mcattamoredhat
force-pushed
the
rc-compose-tier1-testing
branch
from
July 30, 2026 14:53
6402f1a to
697d306
Compare
mcattamoredhat
marked this pull request as ready for review
July 31, 2026 15:01
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to allow installing greenboot RPM packages from a given RHEL compose as an alternative to the default Copr-based install, and extends bootc test coverage to RHEL 9.9 and RHEL 10.3.
ci: allow installing greenboot from compose RPMs as an alternative to Copr
Copr remains the default source for greenboot builds in the qcow2, anaconda-iso, and ostree CI test cases. When both
DOWNLOAD_NODEandCOMPOSE_IDenvironment variables are set, these tests instead fetch pre-built greenboot RPMs directly from the RHEL compose available at theDOWNLOAD_NODEURL. This is primarily useful for RHEL targets (9.8, 9.9, 10.2, 10.3), where Copr can only provide a CentOS Stream approximation, andmakes local testing against specific RC or nightly composes simpler and more automated.
The RPM download logic has been extracted into a shared helper (
tests/common/download-compose-rpms.sh) to avoid duplication across scripts. The helper fetches the packages index page once and reuses it for both RPM lookups.ci: add RHEL 9.9 and RHEL 10.3 support to bootc test cases
Extends the bootc qcow2 and anaconda-iso test scripts to support RHEL 9.9 and RHEL 10.3 alongside the existing 9.8 and 10.2 variants. Each new distro gets its own DNF repo file with
REPLACE_ME_HEREandREPLACE_ARCH_HEREplaceholders substituted at runtime fromDOWNLOAD_NODEand the detected architecture, respectively. CI jobsrhel-9-9-bootcandrhel-10-3-bootcare added togreenboot-ci.yamltargeting the corresponding nightly composes.Local testing (compose RPM mode)
Run each script directly on a host matching the target distro, from inside the
tests/directory.greenboot-bootc-anaconda-iso.shgreenboot-bootc-qcow2.shgreenboot-ostree.shAssisted-by: Claude (claude-sonnet-5)