Skip to content

Commit 1cfd0ea

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md
1 parent eee5267 commit 1cfd0ea

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

Diff for: .github/PULL_REQUEST_TEMPLATE.md

+14-7
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,23 @@ Description:简要描述这次PR的内容
22

33
Main reason: 做出这次修改的原因
44

5+
56
Checklist 检查下面各项是否完成
67

78
Please feel free to remove inapplicable items for your PR.
89

9-
- [ ] The PR title starts with [$CATEGORY] (such as [Models], [Modules], [Core], [io], [Doc], 分别对应各个子模块)
10-
- [ ] Changes are complete (i.e. I finished coding on this PR) 代码写完了
11-
- [ ] All changes have test coverage 修改的地方经过测试。对于可复用部分的修改,例如core/和modules/,测试代码必须提供。其他部分建议提供
12-
- [ ] Code is well-documented 注释写好,文档会从注释中自动抽取
13-
- [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change 这种情况请找核心开发人员
10+
- [ ] The PR title starts with [$CATEGORY] (例如[bugfix]修复bug,[new]添加新功能,[test]修改测试,[rm]删除旧代码)
11+
- [ ] Changes are complete (i.e. I finished coding on this PR) 修改完成才提PR
12+
- [ ] All changes have test coverage 修改的部分顺利通过测试。对于fastnlp/fastnlp/*的修改,测试代码**必须**提供在fastnlp/test/*
13+
- [ ] Code is well-documented 注释写好,API文档会从注释中抽取
14+
- [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change 修改导致例子或tutorial有变化,请找核心开发人员
1415

1516
Changes: 逐项描述修改的内容
16-
- Switch to sparse_coo_matrix for torch v1.0. #282
17-
- Fix bug that nx graph to dgl graph is not properly converted. #286
17+
- 添加了新模型;用于句子分类的CNN,来自Yoon Kim的Convolutional Neural Networks for Sentence Classification
18+
- 修改dataset.py中过时的和不合规则的注释 #286
19+
- 添加对var-LSTM的测试代码
20+
21+
Mention: 找人review你的PR
22+
23+
@修改过这个文件的人
24+
@核心开发人员

0 commit comments

Comments
 (0)