From f5f6581e6754f06eccba6c5ba35834c917cf226d Mon Sep 17 00:00:00 2001
From: Domagoj Potkoc <domagoj@favicode.net>
Date: Tue, 17 Dec 2024 11:54:12 +0100
Subject: [PATCH] waf removing

---
 .../FastlyCdn/Waf/AbstractWafUpdate.php       |  25 ---
 .../FastlyCdn/Waf/CheckWafBypassSetting.php   | 106 ----------
 .../FastlyCdn/Waf/GetWafSettings.php          | 100 ----------
 .../FastlyCdn/Waf/UpdateWafAllowlist.php      | 183 ------------------
 .../Adminhtml/FastlyCdn/Waf/WafAllowlist.php  | 181 -----------------
 5 files changed, 595 deletions(-)
 delete mode 100644 Controller/Adminhtml/FastlyCdn/Waf/AbstractWafUpdate.php
 delete mode 100644 Controller/Adminhtml/FastlyCdn/Waf/CheckWafBypassSetting.php
 delete mode 100644 Controller/Adminhtml/FastlyCdn/Waf/GetWafSettings.php
 delete mode 100644 Controller/Adminhtml/FastlyCdn/Waf/UpdateWafAllowlist.php
 delete mode 100644 Controller/Adminhtml/FastlyCdn/Waf/WafAllowlist.php

diff --git a/Controller/Adminhtml/FastlyCdn/Waf/AbstractWafUpdate.php b/Controller/Adminhtml/FastlyCdn/Waf/AbstractWafUpdate.php
deleted file mode 100644
index 1835d318..00000000
--- a/Controller/Adminhtml/FastlyCdn/Waf/AbstractWafUpdate.php
+++ /dev/null
@@ -1,25 +0,0 @@
-<?php
-
-namespace Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf;
-
-use Magento\Backend\App\Action;
-
-abstract class AbstractWafUpdate extends Action
-{
-    const ADMIN_RESOURCE = 'Magento_Config::config';
-
-    /**
-     * @param string[] $acls
-     * @return string
-     */
-    protected function prepareWafAllowlist(array $acls): string
-    {
-        $list = [];
-
-        foreach ($acls as $acl) {
-            $list[] = sprintf('req.http.Fastly-Client-Ip ~ %s', $acl);
-        }
-
-        return implode(' || ', $list);
-    }
-}
diff --git a/Controller/Adminhtml/FastlyCdn/Waf/CheckWafBypassSetting.php b/Controller/Adminhtml/FastlyCdn/Waf/CheckWafBypassSetting.php
deleted file mode 100644
index 29006a57..00000000
--- a/Controller/Adminhtml/FastlyCdn/Waf/CheckWafBypassSetting.php
+++ /dev/null
@@ -1,106 +0,0 @@
-<?php
-/**
- * Fastly CDN for Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Fastly CDN for Magento End User License Agreement
- * that is bundled with this package in the file LICENSE_FASTLY_CDN.txt.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Fastly CDN to newer
- * versions in the future. If you wish to customize this module for your
- * needs please refer to http://www.magento.com for more information.
- *
- * @category    Fastly
- * @package     Fastly_Cdn
- * @copyright   Copyright (c) 2016 Fastly, Inc. (http://www.fastly.com)
- * @license     BSD, see LICENSE_FASTLY_CDN.txt
- */
-namespace Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf;
-
-use Fastly\Cdn\Model\Config;
-use Fastly\Cdn\Model\Api;
-use Magento\Backend\App\Action;
-use Magento\Backend\App\Action\Context;
-use Magento\Framework\Controller\Result\Json;
-use Magento\Framework\Controller\Result\JsonFactory;
-
-/**
- * Class CheckWafBypassSetting
- *
- * @package Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf
- */
-class CheckWafBypassSetting extends Action
-{
-    const ADMIN_RESOURCE = 'Magento_Config::config';
-
-    /**
-     * @var Api
-     */
-    private $api;
-    /**
-     * @var Config
-     */
-    private $config;
-    /**
-     * @var JsonFactory
-     */
-    private $resultJsonFactory;
-
-    /**
-     * CheckWafBypassSetting constructor.
-     *
-     * @param Context $context
-     * @param Config $config
-     * @param Api $api
-     * @param JsonFactory $resultJsonFactory
-     */
-    public function __construct(
-        Context $context,
-        Config $config,
-        Api $api,
-        JsonFactory $resultJsonFactory
-    ) {
-        $this->api = $api;
-        $this->config = $config;
-        $this->resultJsonFactory = $resultJsonFactory;
-
-        parent::__construct($context);
-    }
-
-    /**
-     * Verifies whether or not the WAF bypass settings snippet exists on specified Fastly version
-     *
-     * @return Json
-     */
-    public function execute()
-    {
-        $result = $this->resultJsonFactory->create();
-        return $result->setData([
-            'status'    => false,
-            'msg'       => 'Deprecated functionality',
-        ]);
-        try {
-            $activeVersion = $this->getRequest()->getParam('active_version');
-            $req = $this->api->hasSnippet($activeVersion, Config::WAF_SETTING_NAME);
-
-            if ($req == false) {
-                return $result->setData([
-                    'status' => false
-                ]);
-            }
-
-            return $result->setData([
-                'status'        => true,
-                'req_setting'   => $req
-            ]);
-        } catch (\Exception $e) {
-            return $result->setData([
-                'status'    => false,
-                'msg'       => $e->getMessage()
-            ]);
-        }
-    }
-}
diff --git a/Controller/Adminhtml/FastlyCdn/Waf/GetWafSettings.php b/Controller/Adminhtml/FastlyCdn/Waf/GetWafSettings.php
deleted file mode 100644
index a45e5123..00000000
--- a/Controller/Adminhtml/FastlyCdn/Waf/GetWafSettings.php
+++ /dev/null
@@ -1,100 +0,0 @@
-<?php
-/**
- * Fastly CDN for Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Fastly CDN for Magento End User License Agreement
- * that is bundled with this package in the file LICENSE_FASTLY_CDN.txt.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Fastly CDN to newer
- * versions in the future. If you wish to customize this module for your
- * needs please refer to http://www.magento.com for more information.
- *
- * @category    Fastly
- * @package     Fastly_Cdn
- * @copyright   Copyright (c) 2016 Fastly, Inc. (http://www.fastly.com)
- * @license     BSD, see LICENSE_FASTLY_CDN.txt
- */
-namespace Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf;
-
-use Fastly\Cdn\Model\Config;
-use Fastly\Cdn\Model\Api;
-use Magento\Backend\App\Action;
-use Magento\Backend\App\Action\Context;
-use Magento\Framework\Controller\Result\Json;
-use Magento\Framework\Controller\Result\JsonFactory;
-
-/**
- * Class GetWafSettings
- *
- * @package Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf
- */
-class GetWafSettings extends Action
-{
-    const ADMIN_RESOURCE = 'Magento_Config::config';
-
-    /**
-     * @var Api
-     */
-    private $api;
-    /**
-     * @var Config
-     */
-    private $config;
-    /**
-     * @var JsonFactory
-     */
-    private $resultJsonFactory;
-
-    /**
-     * GetFastlyServiceInfo constructor.
-     *
-     * @param Context $context
-     * @param Config $config
-     * @param Api $api
-     * @param JsonFactory $resultJsonFactory
-     */
-    public function __construct(
-        Context $context,
-        Config $config,
-        Api $api,
-        JsonFactory $resultJsonFactory
-    ) {
-        $this->api = $api;
-        $this->config = $config;
-        $this->resultJsonFactory = $resultJsonFactory;
-
-        parent::__construct($context);
-    }
-
-    /**
-     * @return \Magento\Framework\App\ResponseInterface|Json|\Magento\Framework\Controller\ResultInterface
-     */
-    public function execute()
-    {
-        $result = $this->resultJsonFactory->create();
-        return $result->setData([
-            'status'    => false,
-            'msg'       => 'Deprecated functionality',
-        ]);
-        try {
-            $id = (string)$this->getRequest()->getParam('id');
-            $includeWafFirewallVersion = (bool)$this->getRequest()
-                ->getParam('include_waf_firewall_versions', false);
-            $wafSettings = $this->api->getWafSettings($id, $includeWafFirewallVersion);
-
-            return $result->setData([
-                'status'        => true,
-                'waf_settings'  => $wafSettings
-            ]);
-        } catch (\Exception $e) {
-            return $result->setData([
-                'status'    => false,
-                'msg'       => $e->getMessage()
-            ]);
-        }
-    }
-}
diff --git a/Controller/Adminhtml/FastlyCdn/Waf/UpdateWafAllowlist.php b/Controller/Adminhtml/FastlyCdn/Waf/UpdateWafAllowlist.php
deleted file mode 100644
index f99c9570..00000000
--- a/Controller/Adminhtml/FastlyCdn/Waf/UpdateWafAllowlist.php
+++ /dev/null
@@ -1,183 +0,0 @@
-<?php
-/**
- * Fastly CDN for Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Fastly CDN for Magento End User License Agreement
- * that is bundled with this package in the file LICENSE_FASTLY_CDN.txt.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Fastly CDN to newer
- * versions in the future. If you wish to customize this module for your
- * needs please refer to http://www.magento.com for more information.
- *
- * @category    Fastly
- * @package     Fastly_Cdn
- * @copyright   Copyright (c) 2016 Fastly, Inc. (http://www.fastly.com)
- * @license     BSD, see LICENSE_FASTLY_CDN.txt
- */
-namespace Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf;
-
-use Magento\Backend\App\Action;
-use Magento\Backend\App\Action\Context;
-use Magento\Framework\App\Request\Http;
-use Magento\Framework\Controller\Result\JsonFactory;
-use Fastly\Cdn\Model\Config;
-use Fastly\Cdn\Model\Api;
-use Fastly\Cdn\Helper\Vcl;
-use Magento\Framework\App\Config\Storage\WriterInterface as ConfigWriter;
-use Magento\Framework\App\Cache\TypeListInterface as CacheTypeList;
-use Magento\Config\App\Config\Type\System as SystemConfig;
-
-/**
- * Class UpdateWafAllowlist
- *
- * @package Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf
- */
-class UpdateWafAllowlist extends AbstractWafUpdate
-{
-    /**
-     * @var Http
-     */
-    private $request;
-    /**
-     * @var JsonFactory
-     */
-    private $resultJson;
-    /**
-     * @var Config
-     */
-    private $config;
-    /**
-     * @var Api
-     */
-    private $api;
-    /**
-     * @var Vcl
-     */
-    private $vcl;
-    /**
-     * @var ConfigWriter
-     */
-    private $configWriter;
-    /**
-     * @var CacheTypeList
-     */
-    private $cacheTypeList;
-    /**
-     * @var SystemConfig
-     */
-    private $systemConfig;
-
-    /**
-     * UpdateWafAllowlist constructor.
-     *
-     * @param Context $context
-     * @param Http $request
-     * @param JsonFactory $resultJsonFactory
-     * @param Config $config
-     * @param Api $api
-     * @param Vcl $vcl
-     * @param ConfigWriter $configWriter
-     * @param CacheTypeList $cacheTypeList
-     * @param SystemConfig $systemConfig
-     */
-    public function __construct(
-        Context $context,
-        Http $request,
-        JsonFactory $resultJsonFactory,
-        Config $config,
-        Api $api,
-        Vcl $vcl,
-        ConfigWriter $configWriter,
-        CacheTypeList $cacheTypeList,
-        SystemConfig $systemConfig
-    ) {
-        $this->request = $request;
-        $this->resultJson = $resultJsonFactory;
-        $this->config = $config;
-        $this->api = $api;
-        $this->vcl = $vcl;
-        $this->configWriter = $configWriter;
-        $this->cacheTypeList = $cacheTypeList;
-        $this->systemConfig = $systemConfig;
-        parent::__construct($context);
-    }
-
-    /**
-     * Upload WAF Bypass snippets
-     *
-     * @return $this|\Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\ResultInterface
-     */
-    public function execute()
-    {
-        $result = $this->resultJson->create();
-        return $result->setData([
-            'status'    => false,
-            'msg'       => 'Deprecated functionality',
-        ]);
-        try {
-            $service = $this->api->checkServiceDetails();
-            $currActiveVersion = $this->vcl->determineVersions($service->versions);
-
-            $snippet = $this->config->getVclSnippets(
-                Config::VCL_WAF_PATH,
-                Config::VCL_WAF_ALLOWLIST_SNIPPET
-            );
-
-            $acls = $this->getParamArray('acls');
-            $this->configWriter->save(
-                Config::XML_FASTLY_WAF_ALLOW_BY_ACL,
-                implode(',', $acls),
-                'default',
-                '0'
-            );
-
-            $wafAllowlist = $this->prepareWafAllowlist($acls);
-
-            // Add WAF bypass snippet
-            foreach ($snippet as $key => $value) {
-                $value = $wafAllowlist !== '' ?
-                    str_replace('####WAF_ALLOWLIST####', $wafAllowlist, $value) :
-                    '';
-
-                $snippetName = Config::FASTLY_MAGENTO_MODULE . '_waf_' . $key;
-                $snippetId = $this->api->getSnippet($currActiveVersion['active_version'], $snippetName)->id;
-                $params = [
-                    'name'      => $snippetId,
-                    'content'   => $value
-                ];
-
-                $this->api->updateSnippet($params);
-            }
-
-            $this->cacheTypeList->cleanType('config');
-            $this->systemConfig->clean();
-
-            return $result->setData([
-                'status' => true
-            ]);
-        } catch (\Exception $e) {
-            return $result->setData([
-                'status'    => false,
-                'msg'       => $e->getMessage()
-            ]);
-        }
-    }
-
-    protected function getParamArray(string $param): array
-    {
-        $request = $this->getRequest();
-
-        $data = $request->getParam($param);
-        if (empty($data)) {
-            return [];
-        }
-
-        return array_map(static function ($row) {
-            return $row['value'];
-        }, $data);
-    }
-}
diff --git a/Controller/Adminhtml/FastlyCdn/Waf/WafAllowlist.php b/Controller/Adminhtml/FastlyCdn/Waf/WafAllowlist.php
deleted file mode 100644
index ddcaa109..00000000
--- a/Controller/Adminhtml/FastlyCdn/Waf/WafAllowlist.php
+++ /dev/null
@@ -1,181 +0,0 @@
-<?php
-/**
- * Fastly CDN for Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Fastly CDN for Magento End User License Agreement
- * that is bundled with this package in the file LICENSE_FASTLY_CDN.txt.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Fastly CDN to newer
- * versions in the future. If you wish to customize this module for your
- * needs please refer to http://www.magento.com for more information.
- *
- * @category    Fastly
- * @package     Fastly_Cdn
- * @copyright   Copyright (c) 2016 Fastly, Inc. (http://www.fastly.com)
- * @license     BSD, see LICENSE_FASTLY_CDN.txt
- */
-namespace Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf;
-
-use Magento\Backend\App\Action\Context;
-use Magento\Framework\App\Request\Http;
-use Magento\Framework\Controller\Result\JsonFactory;
-use Fastly\Cdn\Model\Config;
-use Fastly\Cdn\Model\Api;
-use Fastly\Cdn\Helper\Vcl;
-
-/**
- * @deprecad
- * Class WafAllowlist
- *
- * @package Fastly\Cdn\Controller\Adminhtml\FastlyCdn\Waf
- */
-class WafAllowlist extends AbstractWafUpdate
-{
-    /**
-     * @var Http
-     */
-    private $request;
-    /**
-     * @var JsonFactory
-     */
-    private $resultJson;
-    /**
-     * @var Config
-     */
-    private $config;
-    /**
-     * @var Api
-     */
-    private $api;
-    /**
-     * @var Vcl
-     */
-    private $vcl;
-
-    /**
-     * WafAllowlist constructor.
-     *
-     * @param Context $context
-     * @param Http $request
-     * @param JsonFactory $resultJsonFactory
-     * @param Config $config
-     * @param Api $api
-     * @param Vcl $vcl
-     */
-    public function __construct(
-        Context $context,
-        Http $request,
-        JsonFactory $resultJsonFactory,
-        Config $config,
-        Api $api,
-        Vcl $vcl
-    ) {
-        $this->request = $request;
-        $this->resultJson = $resultJsonFactory;
-        $this->config = $config;
-        $this->api = $api;
-        $this->vcl = $vcl;
-        parent::__construct($context);
-    }
-
-    /**
-     * Upload WAF allowlist snippet
-     *
-     * @return \Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\Result\Json|\Magento\Framework\Controller\ResultInterface
-     */
-    public function execute()
-    {
-        $result = $this->resultJson->create();
-        return $result->setData([
-            'status'    => false,
-            'msg'       => 'Deprecated functionality',
-        ]);
-        try {
-            $activeVersion = $this->getRequest()->getParam('active_version');
-            $activateVcl = $this->getRequest()->getParam('activate_flag');
-            $service = $this->api->checkServiceDetails();
-            $this->vcl->checkCurrentVersionActive($service->versions, $activeVersion);
-            $currActiveVersion = $this->vcl->getCurrentVersion($service->versions);
-            $clone = $this->api->cloneVersion($currActiveVersion);
-
-            $checkIfSettingExists = $this->api->hasSnippet($activeVersion, Config::WAF_SETTING_NAME);
-            $snippet = $this->config->getVclSnippets(
-                Config::VCL_WAF_PATH,
-                Config::VCL_WAF_ALLOWLIST_SNIPPET
-            );
-
-            $acls = $this->config->getWafAllowByAcl();
-            $acls = !empty($acls) ?
-                explode(',', $acls) :
-                [];
-
-            $wafAllowlist = $this->prepareWafAllowlist($acls);
-
-            if (!$checkIfSettingExists) {
-                // Add WAF allowlist snippet
-                foreach ($snippet as $key => $value) {
-                    $value = $wafAllowlist !== '' ?
-                        str_replace('####WAF_ALLOWLIST####', $wafAllowlist, $value) :
-                        '';
-
-                    $snippetData = [
-                        'name'      => Config::FASTLY_MAGENTO_MODULE . '_waf_' . $key,
-                        'type'      => $key,
-                        'dynamic'   => 1,
-                        'priority'  => 10,
-                        'content'   => $value
-                    ];
-
-                    $this->api->uploadSnippet($clone->number, $snippetData);
-                }
-            } else {
-                // Remove WAF allowlist snippet
-                foreach ($snippet as $key => $value) {
-                    $name = Config::FASTLY_MAGENTO_MODULE . '_waf_' . $key;
-                    if ($this->api->hasSnippet($clone->number, $name) == true) {
-                        $this->api->removeSnippet($clone->number, $name);
-                    }
-                }
-            }
-
-            $this->api->validateServiceVersion($clone->number);
-
-            if ($activateVcl === 'true') {
-                $this->api->activateVersion($clone->number);
-            }
-
-            $this->sendWebhook($checkIfSettingExists, $clone);
-
-            $comment = ['comment' => 'Magento Module turned ON WAF ACL Bypass'];
-            if ($checkIfSettingExists) {
-                $comment = ['comment' => 'Magento Module turned OFF WAF ACL Bypass'];
-            }
-            $this->api->addComment($clone->number, $comment);
-
-            return $result->setData([
-                'status' => true
-            ]);
-        } catch (\Exception $e) {
-            return $result->setData([
-                'status'    => false,
-                'msg'       => $e->getMessage()
-            ]);
-        }
-    }
-
-    private function sendWebhook($checkIfSettingExists, $clone)
-    {
-        if ($this->config->areWebHooksEnabled() && $this->config->canPublishConfigChanges()) {
-            if ($checkIfSettingExists) {
-                $this->api->sendWebHook('
-                *WAF ACL Bypass has been turned OFF in Fastly version ' . $clone->number . '*');
-            } else {
-                $this->api->sendWebHook('*WAF ACL Bypass has been turned ON in Fastly version ' . $clone->number . '*');
-            }
-        }
-    }
-}