Merge pull request #224 from Coeur/coeur/input_num

lemire · web-flow · commit 736561cd99e0 · 2023-11-27T15:51:37.000-05:00
float_common.h:237:52 Value stored to 'input_num' is never read
diff --git a/include/fast_float/float_common.h b/include/fast_float/float_common.h
@@ -234,7 +234,7 @@ int leading_zeroes_generic(uint64_t input_num, int last_bit = 0) {
     if(input_num & uint64_t(            0xff00)) { input_num >>=  8; last_bit |=  8; }
     if(input_num & uint64_t(              0xf0)) { input_num >>=  4; last_bit |=  4; }
     if(input_num & uint64_t(               0xc)) { input_num >>=  2; last_bit |=  2; }
-    if(input_num & uint64_t(               0x2)) { input_num >>=  1; last_bit |=  1; }
+    if(input_num & uint64_t(               0x2)) { /* input_num >>=  1; */ last_bit |=  1; }
     return 63 - last_bit;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ int leading_zeroes_generic(uint64_t input_num, int last_bit = 0) {`
`234`	`234`	`if(input_num & uint64_t( 0xff00)) { input_num >>= 8; last_bit \|= 8; }`
`235`	`235`	`if(input_num & uint64_t( 0xf0)) { input_num >>= 4; last_bit \|= 4; }`
`236`	`236`	`if(input_num & uint64_t( 0xc)) { input_num >>= 2; last_bit \|= 2; }`
`237`		`- if(input_num & uint64_t( 0x2)) { input_num >>= 1; last_bit \|= 1; }`
	`237`	`+ if(input_num & uint64_t( 0x2)) { /* input_num >>= 1; */ last_bit \|= 1; }`
`238`	`238`	`return 63 - last_bit;`
`239`	`239`	`}`
`240`	`240`