Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The id generated for a Java class without any package contains "null" #138

Open
tmortagne opened this issue Nov 25, 2020 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@tmortagne
Copy link
Member

To Reproduce

Analyze a java class MyClass with no package: you end up with a JSON containing:

"internalTypes": {"/null/MyClass": {

in the produced JSON.

Expected behavior

I feel that en empty string (so "//MyClass") would make more sense than "null".

@tmortagne tmortagne added the bug Something isn't working label Feb 9, 2021
@proksch
Copy link
Contributor

proksch commented Jan 30, 2022

I would argue that the correct type for classes in the default package should be /MyClass.

@ashkboos The issue report is quite old by now... how has the handling been changed in the meantime?

@proksch
Copy link
Contributor

proksch commented Mar 10, 2022

Please make sure that this is not forgotten... please also consider #248 and #260 as all of them are related to FastenURIs.

@ashkboos
Copy link
Contributor

@proksch I thought about these issues a lot. All of them are somehow related to the FastenUris design. We can perhaps spend some time and do some workarounds to hide them but I'm not sure it is worth the time. I think a proper solution is as you mentioned an ANTLR-based solution or sth similar.

@proksch
Copy link
Contributor

proksch commented Mar 10, 2022

Can you make an example? Which constructs cannot be expressed in a FastenUri?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants