Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated Twitter Icon (Bird Logo) Still Displayed After Rebranding to "X" #495

Closed
mohit-1710 opened this issue Oct 10, 2024 · 6 comments · Fixed by #594
Closed

Outdated Twitter Icon (Bird Logo) Still Displayed After Rebranding to "X" #495

mohit-1710 opened this issue Oct 10, 2024 · 6 comments · Fixed by #594
Assignees
@ahmedhalac
Labels
design enhancement New feature request good first issue Good for newcomers

Comments

@mohit-1710
Copy link

Outdated Twitter Icon (Bird Logo) Still Displayed After Rebranding to "X"

Issue Description:
On the website, the Twitter icon is still showing the old bird logo instead of the updated X logo.

Steps to Reproduce

Steps to Reproduce:

  1. Navigate to the beta.fallingfruit.org
  2. Observe the Twitter icon.

Screenshots

image
@mohit-1710
Copy link
Author

@ezwelty please assign this issue to me .

@ezwelty ezwelty added enhancement New feature request design labels Oct 10, 2024
@ezwelty
Copy link
Collaborator

ezwelty commented Oct 10, 2024

@mohit-1710 Done! Also please update the URL to https://x.com/Falling_Fruit

I'll miss the bird though 😢

@wbazant
Copy link
Collaborator

wbazant commented Oct 27, 2024

Hi @mohit-1710 , would you like to stay assigned to this issue? If you still want to solve it but are stuck on something, feel free to describe the problem and I'll try to unblock you. If you're not working on it any more but made partial progress, you can also update the issue with notes and someone solving it might find it helpful.

@wbazant wbazant added the good first issue Good for newcomers label Nov 10, 2024
@ahmedhalac
Copy link
Contributor

@wbazant. Can you assign me on this too?

@ahmedhalac
Copy link
Contributor

ahmedhalac commented Nov 13, 2024 •
edited
Loading

Quick question: Since I can't find X icon in @styled-icons/boxicons, is using an svg good idea?
I found this svg from the Font Awesome, looks ok to me.

Screenshot 2024-11-13 at 10 47 58 PM

@wbazant
Copy link
Collaborator

wbazant commented Nov 14, 2024

Yeah, that works! I found a boxicons thread about it: atisawd/boxicons#921 (comment) and a person there made a proposal, check out that one too?

ahmedhalac added a commit to ahmedhalac/falling-fruit-web that referenced this issue Nov 14, 2024
@ahmedhalac
feat(falling-fruit#495): Change outdated twitter icon
dc4fb56 
Related to falling-fruit#495
@ahmedhalac ahmedhalac mentioned this issue Nov 14, 2024
Merged
ahmedhalac added a commit to ahmedhalac/falling-fruit-web that referenced this issue Nov 15, 2024
@ahmedhalac
Merge branch 'main' into feature/falling-fruit#495-change-outdated-tw…
ed37f3a 
…itter-logo
ahmedhalac added a commit to ahmedhalac/falling-fruit-web that referenced this issue Nov 15, 2024
@ahmedhalac
fix(falling-fruit#495): changed svg name
5a6c27e 
Related to falling-fruit#495
ahmedhalac added a commit to ahmedhalac/falling-fruit-web that referenced this issue Nov 15, 2024
@ahmedhalac
fix(falling-fruit#495): fixed wrong formatting for login page
fdfddd0
ahmedhalac added a commit to ahmedhalac/falling-fruit-web that referenced this issue Nov 17, 2024
@ahmedhalac
fix(falling-fruit#495): solved less bold issue for X icon
b4a646c
ahmedhalac added a commit to ahmedhalac/falling-fruit-web that referenced this issue Nov 17, 2024
@ahmedhalac
Merge branch 'main' into feature/falling-fruit#495-change-outdated-tw…
2206aeb 
…itter-logo
wbazant pushed a commit that referenced this issue Nov 17, 2024
@ahmedhalac
feat(#495): Change outdated twitter icon (#594)
0d8e630 
* feat(#495): Change outdated twitter icon

Related to #495

* fix(#495): changed svg name

Related to #495

* fix(#495): fixed wrong formatting for login page

* fix(#495): solved less bold issue for X icon
@ezwelty ezwelty mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmedhalac ahmedhalac

Labels
design enhancement New feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#495): Change outdated twitter icon ahmedhalac/falling-fruit-web
4 participants
@ezwelty @wbazant @ahmedhalac @mohit-1710