Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify review text and design #490

Open
ezwelty opened this issue Oct 9, 2024 · 1 comment
Open

Simplify review text and design #490

ezwelty opened this issue Oct 9, 2024 · 1 comment
Labels

Comments

@ezwelty
Copy link
Collaborator

ezwelty commented Oct 9, 2024

Spurred by #487.

There are many ways we could display a review because we have two (three) different dates associated with reviews: observed_on (manually entered), created_at (creation date), updated_at (creation or last edit date) and either an associated author and/or user_id or not. If the latter two are defined, then in the near future we will want author name to link to a user_id profile page.

I think we could redesign with an eye towards visual simplicity and ease of translation.

User and date

The first line could simply be:

{user} · {date}

where {user} is:

  • if author and not user_id: <UserIcon> {author}
  • if author and user_id (once profile pages exist): <a href="{user_id}"><UserIcon> {author}</a>
  • else: omitted or <AnonymousIcon>

and {date} is:

  • if observed_on: observed {observed_on}
  • if updated_at > created_at: {updated_at}
  • else {created_at}

I think it is important to highlight observed_on, but not necessary to distinguish between created_at and updated_at. Thoughts?

Own reviews

For reviews by the logged in user, I think "You reviewed this location on {date}" could be replaced by styling of the {user} element (e.g. user name in bold?). The current grey background (but a lighter grey?) for these reviews might be nice applied to all reviews, to help separate them from the background and each other.

"Update or delete this review." could be replaced with a small edit icon and delete icon (or small text links "edit" and "delete").

Tags

Fruiting status, quality rating, and yield rating could be placed on one line as done on the current website.

Fruiting status {fruiting} · Quality {quality} · Yield {yield}

@ezwelty ezwelty added enhancement New feature request design and removed enhancement New feature request labels Oct 9, 2024
@wbazant
Copy link
Collaborator

wbazant commented Dec 15, 2024

Also related: #446 about the review summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants