Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk editing all users as admin removes other admins #1309

Open
1 task done
Radiicall opened this issue Jan 27, 2025 · 3 comments
Open
1 task done

Bulk editing all users as admin removes other admins #1309

Radiicall opened this issue Jan 27, 2025 · 3 comments
Assignees
Labels
bug Something isn't working confirmed This bug has been reproduced

Comments

@Radiicall
Copy link

Description

When editing user perms as admin other admins are usually greyed out but if you bulk edit and click the all users checkbox then it will still edit the admins, thus removing their administrative permission.

Version

2.3.0

Steps to Reproduce

  1. Go to Users AS AN ADMIN NOT OWNER
  2. Click the checkbox for all users and then click bulk edit
  3. Change the permissions to anything
  4. Other admins have been demoted to normal users

Screenshots

Image
Image
Image

Logs

Platform

desktop

Database

SQLite (default)

Device

Desktop

Operating System

Any

Browser

Zen Browser (Firefox based)

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@Radiicall Radiicall added awaiting triage This issue needs to be reviewed bug Something isn't working labels Jan 27, 2025
@fallenbagel
Copy link
Owner

fallenbagel commented Jan 27, 2025

What do you mean? This is working as intended?
When you bulk edit you're given a clean slate of permissions to choose and you're basically removing admin permission from them when you select everyone. Admins can edit other users permissions including other admins. When you edit a single admin if you untick admin permission that user will become a normal user. That's what happens when you bulk edit. You're removing the admin permission from that user.
Bulk edit is not gonna assign completely new permissions when you bulk edit them. Because there is no way to account for difference in permissions of every user sp when you bulk edit and choose everyone you're basically assigning whatever permission you select in the modal. So when you don't select admin you're basically removing admin permissions from them.

@fallenbagel fallenbagel removed bug Something isn't working awaiting triage This issue needs to be reviewed labels Jan 27, 2025
@Radiicall
Copy link
Author

What do you mean? This is working as intended?

When you bulk edit you're given a clean slate of permissions to choose and you're basically removing admin permission from them when you select everyone. Admins can edit other users permissions including other admins. When you edit a single admin if you untick admin permission that user will become a normal user. That's what happens when you bulk edit. You're removing the admin permission from that user.

Bulk edit is not gonna assign completely new permissions when you bulk edit them. Because there is no way to account for difference in permissions of every user sp when you bulk edit and choose everyone you're basically assigning whatever permission you select in the modal. So when you don't select admin you're basically removing admin permissions from them.

The reason i thought this wasnt intended was because when trying to edit the other admin without using the bulk tool then every permission is completely grayed out and i cant remove their admin

@fallenbagel
Copy link
Owner

fallenbagel commented Jan 27, 2025

@Radiicall nevermind you're right. I got confused, I apologise 😅

Yes an admin shouldn't be able to remove another admins perms

@fallenbagel fallenbagel added the bug Something isn't working label Jan 27, 2025
@fallenbagel fallenbagel reopened this Jan 27, 2025
@fallenbagel fallenbagel added the confirmed This bug has been reproduced label Jan 27, 2025
@gauthier-th gauthier-th self-assigned this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This bug has been reproduced
Projects
None yet
Development

No branches or pull requests

3 participants