flip order of eval for binary matching

falconindy · falconindy · commit 275a1a2ac931 · 2025-03-01T14:08:05.000-05:00
The string matching on the filename is capable of discarding matches far
faster than the binary filter, so switching the order of these two is a
free 20% latency decrease.
diff --git a/src/pkgfile.cc b/src/pkgfile.cc
@@ -328,7 +328,7 @@ std::unique_ptr<filter::Filter> Pkgfile::BuildFilterFromOptions(
   if (options.mode == MODE_SEARCH) {
     if (options.binaries) {
       filter = std::make_unique<filter::And>(
-          std::make_unique<filter::Bin>(bins_), std::move(filter));
+          std::move(filter), std::make_unique<filter::Bin>(bins_));
     }
 
     if (!options.directories) {

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ std::unique_ptr<filter::Filter> Pkgfile::BuildFilterFromOptions(`
`328`	`328`	`if (options.mode == MODE_SEARCH) {`
`329`	`329`	`if (options.binaries) {`
`330`	`330`	`filter = std::make_unique<filter::And>(`
`331`		`- std::make_unique<filter::Bin>(bins_), std::move(filter));`
	`331`	`+ std::move(filter), std::make_unique<filter::Bin>(bins_));`
`332`	`332`	`}`
`333`	`333`
`334`	`334`	`if (!options.directories) {`