Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FairRescoreBuilder: Queue construction for fair Rescore should be reviewed #38

Open
tsuehr opened this issue Oct 30, 2018 · 1 comment
Labels
Internals Statistic and Core internal methods

Comments

@tsuehr
Copy link
Collaborator

tsuehr commented Oct 30, 2018

int max = Math.min(topDocs.scoreDocs.length, rescoreContext.getWindowSize());
at line 277 in FairRescoreBuilder.java will fail at the following example:
Docs in index =25
WindowSize = 10
k=10
Top 9 docs are nonprotected
We will only have one protected element there
for p= 0.8 and alpha = 0,1 we will need 6 protected elements

@tsuehr tsuehr added bug Something isn't working Internals Statistic and Core internal methods labels Oct 30, 2018
@tsuehr tsuehr changed the title FairRescoreBuilder: Queue construction for fair Rescore is wrong FairRescoreBuilder: Queue construction for fair Rescore should be reviewed Oct 31, 2018
@tsuehr tsuehr removed the bug Something isn't working label Oct 31, 2018
@tsuehr
Copy link
Collaborator Author

tsuehr commented Oct 31, 2018

However, this can be seen as intended for very large indices.

Idea: for Index-size<400 execute a full index search for protected documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Statistic and Core internal methods
Projects
None yet
Development

No branches or pull requests

1 participant