Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or document the restriction that index must have at most 1 shard + 1 replica for the plugin to work #36

Open
cristi-maco opened this issue Aug 28, 2018 · 1 comment

Comments

@cristi-maco
Copy link

There is a hard validation in code (in FairRescoreBuilder.java) that checks that the index has only 1 shard (+1 replica).
This means that the plugin is unusable for bigger indexes, which for performance (and/or reliability) reasons need more than 1 shard (or 1 replica) when deployed (like in a production environment).

If this is an unavoidable limitation of the algorithm or the elasticsearch api used by it, please document it clearly in the readme / userguide (currently there is no mention about this), as for many potential users I think this is a very important consideration, which should be known upfront.

If on the other hand this is an avoidable limitation, and the code can be changed/improved so it works with multiple shards, then please consider improving it in this direction.

@cristi-maco cristi-maco changed the title Document restriction that index must have at most 1 shard + 1 replica for the plugin to work Remove or document the restriction that index must have at most 1 shard + 1 replica for the plugin to work Aug 28, 2018
@chatox
Copy link
Contributor

chatox commented Oct 31, 2018

Sorry for the late reply. I think the restriction is not needed, but we will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants