Skip to content

Commit 683d4f1

Browse files
committed
Fix moveBefore feature detection (#32087)
`moveBefore` was moved to the `ParentNode` mixin as per whatwg/dom#1307 (comment) _(and was committed in whatwg/dom@3f3e94c5beda922962dacaeb606087f57bd7f7be)_ As a result, its existence can no longer be checked on `Node.prototype` but must be checked in `Element.prototype` DiffTrain build for [313c8c5](313c8c5)
1 parent 7784671 commit 683d4f1

23 files changed

+92
-92
lines changed

Diff for: compiled-rn/VERSION_NATIVE_FB

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.1.0-native-fb-43d18bc2-20250115
1+
19.1.0-native-fb-313c8c55-20250117

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<df47e386bf1fe5abe7501a1937cbb301>>
10+
* @generated SignedSource<<e70a699a30ca74f9d7860aefcd2b8954>>
1111
*/
1212

1313
"use strict";
@@ -428,5 +428,5 @@ __DEV__ &&
428428
exports.useFormStatus = function () {
429429
return resolveDispatcher().useHostTransitionStatus();
430430
};
431-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
431+
exports.version = "19.1.0-native-fb-313c8c55-20250117";
432432
})();

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cdea6e896a523397ca5640b0abd0d114>>
10+
* @generated SignedSource<<97e18a23e1ca60fdfd2c2b7572bba4b6>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
206+
exports.version = "19.1.0-native-fb-313c8c55-20250117";

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cdea6e896a523397ca5640b0abd0d114>>
10+
* @generated SignedSource<<97e18a23e1ca60fdfd2c2b7572bba4b6>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
206+
exports.version = "19.1.0-native-fb-313c8c55-20250117";

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<95576c45965431f7898adb25c6f79666>>
10+
* @generated SignedSource<<9b5475e6242a629b6837dd80630a5fab>>
1111
*/
1212

1313
/*
@@ -25545,7 +25545,7 @@ __DEV__ &&
2554525545
: scheduleTimeout,
2554625546
supportsMoveBefore =
2554725547
"undefined" !== typeof window &&
25548-
"function" === typeof window.Node.prototype.moveBefore,
25548+
"function" === typeof window.Element.prototype.moveBefore,
2554925549
NotLoaded = 0,
2555025550
Loaded = 1,
2555125551
Errored = 2,
@@ -25957,11 +25957,11 @@ __DEV__ &&
2595725957
};
2595825958
(function () {
2595925959
var isomorphicReactPackageVersion = React.version;
25960-
if ("19.1.0-native-fb-43d18bc2-20250115" !== isomorphicReactPackageVersion)
25960+
if ("19.1.0-native-fb-313c8c55-20250117" !== isomorphicReactPackageVersion)
2596125961
throw Error(
2596225962
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2596325963
(isomorphicReactPackageVersion +
25964-
"\n - react-dom: 19.1.0-native-fb-43d18bc2-20250115\nLearn more: https://react.dev/warnings/version-mismatch")
25964+
"\n - react-dom: 19.1.0-native-fb-313c8c55-20250117\nLearn more: https://react.dev/warnings/version-mismatch")
2596525965
);
2596625966
})();
2596725967
("function" === typeof Map &&
@@ -25998,10 +25998,10 @@ __DEV__ &&
2599825998
!(function () {
2599925999
var internals = {
2600026000
bundleType: 1,
26001-
version: "19.1.0-native-fb-43d18bc2-20250115",
26001+
version: "19.1.0-native-fb-313c8c55-20250117",
2600226002
rendererPackageName: "react-dom",
2600326003
currentDispatcherRef: ReactSharedInternals,
26004-
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
26004+
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
2600526005
};
2600626006
internals.overrideHookState = overrideHookState;
2600726007
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26147,5 +26147,5 @@ __DEV__ &&
2614726147
listenToAllSupportedEvents(container);
2614826148
return new ReactDOMHydrationRoot(initialChildren);
2614926149
};
26150-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
26150+
exports.version = "19.1.0-native-fb-313c8c55-20250117";
2615126151
})();

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4177fd9db345986e60e9ca1ca25f76e5>>
10+
* @generated SignedSource<<9053a0d21feab58b0b8bfced7cee8265>>
1111
*/
1212

1313
/*
@@ -14253,7 +14253,7 @@ function handleErrorInNextTick(error) {
1425314253
}
1425414254
var supportsMoveBefore =
1425514255
"undefined" !== typeof window &&
14256-
"function" === typeof window.Node.prototype.moveBefore;
14256+
"function" === typeof window.Element.prototype.moveBefore;
1425714257
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
1425814258
var node = suspenseInstance,
1425914259
depth = 0;
@@ -15968,14 +15968,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1596815968
};
1596915969
var isomorphicReactPackageVersion$jscomp$inline_1785 = React.version;
1597015970
if (
15971-
"19.1.0-native-fb-43d18bc2-20250115" !==
15971+
"19.1.0-native-fb-313c8c55-20250117" !==
1597215972
isomorphicReactPackageVersion$jscomp$inline_1785
1597315973
)
1597415974
throw Error(
1597515975
formatProdErrorMessage(
1597615976
527,
1597715977
isomorphicReactPackageVersion$jscomp$inline_1785,
15978-
"19.1.0-native-fb-43d18bc2-20250115"
15978+
"19.1.0-native-fb-313c8c55-20250117"
1597915979
)
1598015980
);
1598115981
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -15997,10 +15997,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1599715997
};
1599815998
var internals$jscomp$inline_2241 = {
1599915999
bundleType: 0,
16000-
version: "19.1.0-native-fb-43d18bc2-20250115",
16000+
version: "19.1.0-native-fb-313c8c55-20250117",
1600116001
rendererPackageName: "react-dom",
1600216002
currentDispatcherRef: ReactSharedInternals,
16003-
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
16003+
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
1600416004
};
1600516005
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1600616006
var hook$jscomp$inline_2242 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16106,4 +16106,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1610616106
listenToAllSupportedEvents(container);
1610716107
return new ReactDOMHydrationRoot(initialChildren);
1610816108
};
16109-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
16109+
exports.version = "19.1.0-native-fb-313c8c55-20250117";

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bd521e4a43b2ab4756c72d452819a616>>
10+
* @generated SignedSource<<9fccb2530410d5d87fdbd5f7036ef542>>
1111
*/
1212

1313
/*
@@ -14894,7 +14894,7 @@ function handleErrorInNextTick(error) {
1489414894
}
1489514895
var supportsMoveBefore =
1489614896
"undefined" !== typeof window &&
14897-
"function" === typeof window.Node.prototype.moveBefore;
14897+
"function" === typeof window.Element.prototype.moveBefore;
1489814898
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
1489914899
var node = suspenseInstance,
1490014900
depth = 0;
@@ -16617,14 +16617,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1661716617
};
1661816618
var isomorphicReactPackageVersion$jscomp$inline_1880 = React.version;
1661916619
if (
16620-
"19.1.0-native-fb-43d18bc2-20250115" !==
16620+
"19.1.0-native-fb-313c8c55-20250117" !==
1662116621
isomorphicReactPackageVersion$jscomp$inline_1880
1662216622
)
1662316623
throw Error(
1662416624
formatProdErrorMessage(
1662516625
527,
1662616626
isomorphicReactPackageVersion$jscomp$inline_1880,
16627-
"19.1.0-native-fb-43d18bc2-20250115"
16627+
"19.1.0-native-fb-313c8c55-20250117"
1662816628
)
1662916629
);
1663016630
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16646,10 +16646,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1664616646
};
1664716647
var internals$jscomp$inline_1887 = {
1664816648
bundleType: 0,
16649-
version: "19.1.0-native-fb-43d18bc2-20250115",
16649+
version: "19.1.0-native-fb-313c8c55-20250117",
1665016650
rendererPackageName: "react-dom",
1665116651
currentDispatcherRef: ReactSharedInternals,
16652-
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115",
16652+
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117",
1665316653
getLaneLabelMap: function () {
1665416654
for (
1665516655
var map = new Map(), lane = 1, index$292 = 0;
@@ -16770,4 +16770,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1677016770
listenToAllSupportedEvents(container);
1677116771
return new ReactDOMHydrationRoot(initialChildren);
1677216772
};
16773-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
16773+
exports.version = "19.1.0-native-fb-313c8c55-20250117";

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6f219e9ed966b270c6abe28d9170a3ee>>
10+
* @generated SignedSource<<03fc7add2e1d69fa14c6726377d06d2f>>
1111
*/
1212

1313
/*
@@ -25606,7 +25606,7 @@ __DEV__ &&
2560625606
: scheduleTimeout,
2560725607
supportsMoveBefore =
2560825608
"undefined" !== typeof window &&
25609-
"function" === typeof window.Node.prototype.moveBefore,
25609+
"function" === typeof window.Element.prototype.moveBefore,
2561025610
NotLoaded = 0,
2561125611
Loaded = 1,
2561225612
Errored = 2,
@@ -26018,11 +26018,11 @@ __DEV__ &&
2601826018
};
2601926019
(function () {
2602026020
var isomorphicReactPackageVersion = React.version;
26021-
if ("19.1.0-native-fb-43d18bc2-20250115" !== isomorphicReactPackageVersion)
26021+
if ("19.1.0-native-fb-313c8c55-20250117" !== isomorphicReactPackageVersion)
2602226022
throw Error(
2602326023
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2602426024
(isomorphicReactPackageVersion +
26025-
"\n - react-dom: 19.1.0-native-fb-43d18bc2-20250115\nLearn more: https://react.dev/warnings/version-mismatch")
26025+
"\n - react-dom: 19.1.0-native-fb-313c8c55-20250117\nLearn more: https://react.dev/warnings/version-mismatch")
2602626026
);
2602726027
})();
2602826028
("function" === typeof Map &&
@@ -26059,10 +26059,10 @@ __DEV__ &&
2605926059
!(function () {
2606026060
var internals = {
2606126061
bundleType: 1,
26062-
version: "19.1.0-native-fb-43d18bc2-20250115",
26062+
version: "19.1.0-native-fb-313c8c55-20250117",
2606326063
rendererPackageName: "react-dom",
2606426064
currentDispatcherRef: ReactSharedInternals,
26065-
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
26065+
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
2606626066
};
2606726067
internals.overrideHookState = overrideHookState;
2606826068
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26524,7 +26524,7 @@ __DEV__ &&
2652426524
exports.useFormStatus = function () {
2652526525
return resolveDispatcher().useHostTransitionStatus();
2652626526
};
26527-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
26527+
exports.version = "19.1.0-native-fb-313c8c55-20250117";
2652826528
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2652926529
"function" ===
2653026530
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<05f2a3ba7f0b7d0397114aebba97ae69>>
10+
* @generated SignedSource<<6e44a9c4eeec2df75e1c5e16e235be2d>>
1111
*/
1212

1313
/*
@@ -14253,7 +14253,7 @@ function handleErrorInNextTick(error) {
1425314253
}
1425414254
var supportsMoveBefore =
1425514255
"undefined" !== typeof window &&
14256-
"function" === typeof window.Node.prototype.moveBefore;
14256+
"function" === typeof window.Element.prototype.moveBefore;
1425714257
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
1425814258
var node = suspenseInstance,
1425914259
depth = 0;
@@ -15979,14 +15979,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1597915979
};
1598015980
var isomorphicReactPackageVersion$jscomp$inline_1786 = React.version;
1598115981
if (
15982-
"19.1.0-native-fb-43d18bc2-20250115" !==
15982+
"19.1.0-native-fb-313c8c55-20250117" !==
1598315983
isomorphicReactPackageVersion$jscomp$inline_1786
1598415984
)
1598515985
throw Error(
1598615986
formatProdErrorMessage(
1598715987
527,
1598815988
isomorphicReactPackageVersion$jscomp$inline_1786,
15989-
"19.1.0-native-fb-43d18bc2-20250115"
15989+
"19.1.0-native-fb-313c8c55-20250117"
1599015990
)
1599115991
);
1599215992
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16008,10 +16008,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1600816008
};
1600916009
var internals$jscomp$inline_2244 = {
1601016010
bundleType: 0,
16011-
version: "19.1.0-native-fb-43d18bc2-20250115",
16011+
version: "19.1.0-native-fb-313c8c55-20250117",
1601216012
rendererPackageName: "react-dom",
1601316013
currentDispatcherRef: ReactSharedInternals,
16014-
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
16014+
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
1601516015
};
1601616016
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1601716017
var hook$jscomp$inline_2245 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16271,4 +16271,4 @@ exports.useFormState = function (action, initialState, permalink) {
1627116271
exports.useFormStatus = function () {
1627216272
return ReactSharedInternals.H.useHostTransitionStatus();
1627316273
};
16274-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
16274+
exports.version = "19.1.0-native-fb-313c8c55-20250117";

Diff for: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<459d2e101f76f4fd316aa429d387ad28>>
10+
* @generated SignedSource<<ed6be6602fbeff1613925324886e3267>>
1111
*/
1212

1313
/*
@@ -14898,7 +14898,7 @@ function handleErrorInNextTick(error) {
1489814898
}
1489914899
var supportsMoveBefore =
1490014900
"undefined" !== typeof window &&
14901-
"function" === typeof window.Node.prototype.moveBefore;
14901+
"function" === typeof window.Element.prototype.moveBefore;
1490214902
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
1490314903
var node = suspenseInstance,
1490414904
depth = 0;
@@ -16632,14 +16632,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1663216632
};
1663316633
var isomorphicReactPackageVersion$jscomp$inline_1881 = React.version;
1663416634
if (
16635-
"19.1.0-native-fb-43d18bc2-20250115" !==
16635+
"19.1.0-native-fb-313c8c55-20250117" !==
1663616636
isomorphicReactPackageVersion$jscomp$inline_1881
1663716637
)
1663816638
throw Error(
1663916639
formatProdErrorMessage(
1664016640
527,
1664116641
isomorphicReactPackageVersion$jscomp$inline_1881,
16642-
"19.1.0-native-fb-43d18bc2-20250115"
16642+
"19.1.0-native-fb-313c8c55-20250117"
1664316643
)
1664416644
);
1664516645
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16661,10 +16661,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1666116661
};
1666216662
var internals$jscomp$inline_1888 = {
1666316663
bundleType: 0,
16664-
version: "19.1.0-native-fb-43d18bc2-20250115",
16664+
version: "19.1.0-native-fb-313c8c55-20250117",
1666516665
rendererPackageName: "react-dom",
1666616666
currentDispatcherRef: ReactSharedInternals,
16667-
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115",
16667+
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117",
1666816668
getLaneLabelMap: function () {
1666916669
for (
1667016670
var map = new Map(), lane = 1, index$292 = 0;
@@ -16939,7 +16939,7 @@ exports.useFormState = function (action, initialState, permalink) {
1693916939
exports.useFormStatus = function () {
1694016940
return ReactSharedInternals.H.useHostTransitionStatus();
1694116941
};
16942-
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
16942+
exports.version = "19.1.0-native-fb-313c8c55-20250117";
1694316943
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1694416944
"function" ===
1694516945
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)