: Give THSpinner in .native themed coloring #54456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@howardtingting-coder has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86532694. |
Summary: **__Context__**: - problem: loading indicator is always only 1 color. This means it can't be seen when its background color is light (depends on the background color used for example in a button, the button color can be the same as the indicator color) -- we need to offer a way to customize the indicator's color to effectively contrast the background **__Technical context__**: - css doesn't cascade and html.divs don't inherit css styles from parents in .native - THSpinner's xstyle (var(--...)) doesn't apply to the spinner indicator - this can be mutated through indicatorStyle & passing StyleSheet from react-native for 'color' - we let the caller decide the color theme/scheme because the caller is the one who decides the UI context in which the spinner appears (eg within a grey-ish or white button) **__This diff__**: - add indicatorStyles prop with dark and light mode to give caller the option to determine spinner color based on background of call Differential Revision: D86532694
howardtingting-coder
force-pushed
the
export-D86532694
branch
from
25fcd00 to
cb4c351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
Technical context:
This diff:
Differential Revision: D86532694