Update release processes to update the Hermes versions independently from React Native

Summary: TODO

Differential Revision: D82438054

Author: Jakub Piasecki

.github/actions/create-release/action.yml

@@ -4,6 +4,12 @@ inputs:
   version:
     description: "The version of React Native we want to release. For example 0.75.0-rc.0"
     required: true
+  hermes-version:
+    description: "The version of Hermes to be used in this release. For example 0.14.0"
+    required: true
+  hermes-v1-version:
+    description: "The version of Hermes V1 to be used in this release. For example 250829098.0.0"
+    required: true
   is-latest-on-npm:
     description: "Whether we want to tag this release as latest on NPM"
     required: true
@@ -28,6 +34,8 @@ runs:
       run: |
         node scripts/releases/create-release-commit.js \
           --reactNativeVersion "${{ inputs.version }}" \
+          --hermesVersion "${{ inputs.hermes-version }}" \
+          --hermesV1Version "${{ inputs.hermes-v1-version }}" \
           --tagAsLatestRelease "${{ inputs.is-latest-on-npm }}" \
           --dryRun "${{ inputs.dry-run }}"
         GIT_PAGER=cat git show HEAD

.github/workflows/create-release.yml

@@ -7,6 +7,12 @@ on:
         description: "The version of React Native we want to release. For example 0.75.0-rc.0"
         required: true
         type: string
+      hermes-version:
+        description: "The version of Hermes to be used in this release. For example 0.14.0"
+        required: true
+      hermes-v1-version:
+        description: "The version of Hermes V1 to be used in this release. For example 250829098.0.0"
+        required: true
       is-latest-on-npm:
         description: "Whether we want to tag this release as latest on NPM"
         required: true
@@ -53,5 +59,7 @@ jobs:
         uses: ./.github/actions/create-release
         with:
           version: ${{ inputs.version }}
+          hermes-version: ${{ inputs.hermes-version }}
+          hermes-v1-version: ${{ inputs.hermes-v1-version }}
           is-latest-on-npm: ${{ inputs.is-latest-on-npm }}
           dry-run: ${{ inputs.dry-run }}

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/DependencyUtils.kt

@@ -192,6 +192,7 @@ internal object DependencyUtils {
           )
       )
     } else if (hermesV1Enabled) {
+      // TODO: remove this?
       dependencySubstitution.add(
           Triple(
               "com.facebook.react:hermes-android",

packages/react-native/scripts/hermes/__tests__/hermes-utils-test.js

@@ -22,6 +22,7 @@ const {
   getHermesTagSHA,
   getHermesTarballDownloadPath,
   readHermesTag,
+  readHermesV1Tag,
   setHermesTag,
   shouldUsePrebuiltHermesC,
 } = require('../hermes-utils');
@@ -31,6 +32,7 @@ const os = require('os');
 
 const hermesTag =
   'hermes-2022-04-28-RNv0.69.0-15d07c2edd29a4ea0b8f15ab0588a0c1adb1200f';
+const hermesV1Tag = '250829098.0.0';
 const tarballContents = 'dummy string';
 const hermescContents = 'dummy string';
 const hermesTagSha = '5244f819b2f3949ca94a3a1bf75d54a8ed59d94a';
@@ -183,17 +185,25 @@ describe('hermes-utils', () => {
 
     describe('setHermesTag', () => {
       it('should write tag to .hermesversion file', () => {
-        setHermesTag(hermesTag);
+        setHermesTag(hermesTag, hermesV1Tag);
         expect(
           fs.readFileSync(path.join(SDKS_DIR, '.hermesversion'), {
             encoding: 'utf8',
             flag: 'r',
           }),
         ).toEqual(hermesTag);
+
+        expect(
+          fs.readFileSync(path.join(SDKS_DIR, '.hermesv1version'), {
+            encoding: 'utf8',
+            flag: 'r',
+          }),
+        ).toEqual(hermesV1Tag);
       });
       it('should set Hermes tag and read it back', () => {
-        setHermesTag(hermesTag);
+        setHermesTag(hermesTag, hermesV1Tag);
         expect(readHermesTag()).toEqual(hermesTag);
+        expect(readHermesV1Tag()).toEqual(hermesV1Tag);
       });
     });
 

packages/react-native/scripts/hermes/bump-hermes-version.js

@@ -21,28 +21,37 @@ const inquirer = require('inquirer');
 const {exit} = require('shelljs');
 const yargs = require('yargs');
 
-let argv = yargs.option('t', {
-  alias: 'tag',
-  describe:
-    'Hermes release tag to use for this React Native release, ex. hermes-2022-02-21-RNv0.68.0',
-  required: true,
-}).argv;
+let argv = yargs
+  .option('t', {
+    alias: 'tag',
+    describe:
+      'Hermes release tag to use for this React Native release, ex. hermes-2022-02-21-RNv0.68.0',
+    required: true,
+  })
+  .option('s', {
+    alias: 'v1Tag',
+    describe:
+      'Hermes V1 release tag to use for this React Native release, ex. 250829098.0.0',
+    required: true,
+  }).argv;
 
 async function main() {
   // $FlowFixMe[prop-missing]
   const hermesTag = argv.tag;
+  // $FlowFixMe[prop-missing]
+  const hermesV1Tag = argv.v1Tag;
   const {confirmHermesTag} = await inquirer.prompt({
     type: 'confirm',
     name: 'confirmHermesTag',
-    message: `Do you want to use the Hermes release tagged "${hermesTag}"?`,
+    message: `Do you want to use the Hermes release tagged "${hermesTag}" and Hermes V1 release tagged "${hermesV1Tag}"?`,
   });
 
   if (!confirmHermesTag) {
     console.log('Aborting.');
     return;
   }
 
-  setHermesTag(hermesTag);
+  setHermesTag(hermesTag, hermesV1Tag);
 }
 
 void main().then(() => {

packages/react-native/scripts/hermes/hermes-utils.js

@@ -22,6 +22,7 @@ type BuildType = 'dry-run' | 'release' | 'nightly';
 const SDKS_DIR = path.normalize(path.join(__dirname, '..', '..', 'sdks'));
 const HERMES_DIR = path.join(SDKS_DIR, 'hermes');
 const HERMES_TAG_FILE_PATH = path.join(SDKS_DIR, '.hermesversion');
+const HERMES_V1_TAG_FILE_PATH = path.join(SDKS_DIR, '.hermesv1version');
 const HERMES_SOURCE_TARBALL_BASE_URL =
   'https://github.com/facebook/hermes/tarball/';
 const HERMES_TARBALL_DOWNLOAD_DIR = path.join(SDKS_DIR, 'download');
@@ -66,7 +67,27 @@ function readHermesTag() /*: string */ {
   return 'main';
 }
 
-function setHermesTag(hermesTag /*: string */) {
+function readHermesV1Tag() /*: string */ {
+  if (fs.existsSync(HERMES_V1_TAG_FILE_PATH)) {
+    const data = fs
+      .readFileSync(HERMES_V1_TAG_FILE_PATH, {
+        encoding: 'utf8',
+        flag: 'r',
+      })
+      .trim();
+
+    if (data.length > 0) {
+      return data;
+    } else {
+      throw new Error('[Hermes] .hermesv1version file is empty.');
+    }
+  }
+
+  // TODO: what should be the default here?
+  return 'main';
+}
+
+function setHermesTag(hermesTag /*: string */, hermesV1Tag /*: string */) {
   if (readHermesTag() === hermesTag) {
     // No need to update.
     return;
@@ -76,6 +97,7 @@ function setHermesTag(hermesTag /*: string */) {
     fs.mkdirSync(SDKS_DIR, {recursive: true});
   }
   fs.writeFileSync(HERMES_TAG_FILE_PATH, hermesTag.trim());
+  fs.writeFileSync(HERMES_V1_TAG_FILE_PATH, hermesV1Tag.trim());
   console.log('Hermes tag has been updated. Please commit your changes.');
 }
 
@@ -337,6 +359,7 @@ module.exports = {
   getHermesTarballDownloadPath,
   getHermesPrebuiltArtifactsTarballName,
   readHermesTag,
+  readHermesV1Tag,
   setHermesTag,
   shouldBuildHermesFromSource,
   shouldUsePrebuiltHermesC,

packages/react-native/sdks/hermes-engine/version.properties

@@ -1 +1,2 @@
+HERMES_VERSION_NAME=1000.0.0
 HERMES_V1_VERSION_NAME=250829098.0.0

scripts/releases-ci/__tests__/publish-npm-test.js

@@ -20,6 +20,7 @@ const publishPackageMock = jest.fn();
 const getNpmInfoMock = jest.fn();
 const generateAndroidArtifactsMock = jest.fn();
 const getPackagesMock = jest.fn();
+const updateHermesVersionsToNightlyMock = jest.fn();
 
 const {REPO_ROOT} = require('../../shared/consts');
 const {publishNpm} = require('../publish-npm');
@@ -53,6 +54,9 @@ describe('publish-npm', () => {
         ...jest.requireActual('../../releases/utils/npm-utils'),
         publishPackage: publishPackageMock,
         getNpmInfo: getNpmInfoMock,
+      }))
+      .mock('../../releases/utils/hermes-utils', () => ({
+        updateHermesVersionsToNightly: updateHermesVersionsToNightlyMock,
       }));
   });
 
@@ -98,6 +102,7 @@ describe('publish-npm', () => {
 
       await publishNpm('dry-run');
 
+      expect(updateHermesVersionsToNightlyMock).toHaveBeenCalled();
       expect(setVersionMock).not.toBeCalled();
       expect(updateReactNativeArtifactsMock).toBeCalledWith(version, 'dry-run');
 
@@ -155,6 +160,8 @@ describe('publish-npm', () => {
       // Generate Android artifacts is now delegate to build_android entirely
       expect(generateAndroidArtifactsMock).not.toHaveBeenCalled();
 
+      expect(updateHermesVersionsToNightlyMock).toHaveBeenCalled();
+
       expect(publishPackageMock.mock.calls).toEqual([
         [
           'path/to/monorepo/pkg-a',

scripts/releases-ci/publish-npm.js

@@ -18,6 +18,9 @@ const {
   updateReactNativeArtifacts,
 } = require('../releases/set-rn-artifacts-version');
 const {setVersion} = require('../releases/set-version');
+const {
+  updateHermesVersionsToNightly,
+} = require('../releases/utils/hermes-utils');
 const {getNpmInfo, publishPackage} = require('../releases/utils/npm-utils');
 const {
   publishAndroidArtifactsToMaven,
@@ -96,6 +99,9 @@ async function publishNpm(buildType /*: BuildType */) /*: Promise<void> */ {
 
   // For stable releases, ci job `prepare_package_for_release` handles this
   if (buildType === 'nightly') {
+    // Set hermes versions to latest available
+    await updateHermesVersionsToNightly();
+
     // Set same version for all monorepo packages
     await setVersion(version);
     await publishMonorepoPackages(tag);
@@ -113,6 +119,8 @@ async function publishNpm(buildType /*: BuildType */) /*: Promise<void> */ {
     const packageJson = JSON.parse(packageJsonContent);
 
     if (packageJson.version === '1000.0.0') {
+      // Set hermes versions to latest available
+      await updateHermesVersionsToNightly();
       await updateReactNativeArtifacts(version, buildType);
     }
   }

scripts/releases/__tests__/__fixtures__/set-hermes-versions/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "@react-native/monorepo",
+  "private": true,
+  "version": "1000.0.0"
+}