Skip to content

Conversation

@thegreatercurve
Copy link
Contributor

Description

We're updating the the Flow dom types for event listener options to be more consistent with the spec: https://dom.spec.whatwg.org/#eventtarget.

This diff updates the relevant Flow types in Lexical to now be consistent with the new globals.

Test plan

npm run build-www

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lexical Ready Ready Preview Comment Nov 3, 2025 4:25pm
lexical-playground Ready Ready Preview Comment Nov 3, 2025 4:25pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@thegreatercurve thegreatercurve changed the title Bug/link types Feature: Update Lexical link types for Flow Nov 3, 2025
etrepum
etrepum previously approved these changes Nov 3, 2025
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like maybe it needs an update of flow?

@etrepum etrepum self-requested a review November 3, 2025 16:44
@etrepum etrepum dismissed their stale review November 3, 2025 16:45

Failing unit test

@takuyakanbr
Copy link
Contributor

The typings for the dom library need to be updated in flow-typed. That's where we're pulling the dom types from (as of #7785), since flow-bin is no longer bundling them.

@takuyakanbr
Copy link
Contributor

Changes have been made in #7973

@takuyakanbr takuyakanbr closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants