From 7204b5f1d06b17b8643f60a726fe1322abf787a6 Mon Sep 17 00:00:00 2001
From: QiuyunXie <qxie@celestica.com>
Date: Wed, 15 Oct 2025 10:14:34 -0400
Subject: [PATCH] icecube:config: update fsc config according to thermal fsc
 update

---
 .../platform/configs/icecube/fan_service.json | 118 ++++++------------
 1 file changed, 35 insertions(+), 83 deletions(-)

diff --git a/fboss/platform/configs/icecube/fan_service.json b/fboss/platform/configs/icecube/fan_service.json
index 4b0134d828759..948a9afe88b9c 100644
--- a/fboss/platform/configs/icecube/fan_service.json
+++ b/fboss/platform/configs/icecube/fan_service.json
@@ -2,10 +2,10 @@
   "pwmBoostOnNumDeadFan": 2,
   "pwmBoostOnNumDeadSensor": 0,
   "pwmBoostOnNoQsfpAfterInSec": 0,
-  "pwmBoostValue": 70,
-  "pwmTransitionValue": 45,
-  "pwmLowerThreshold": 25,
-  "pwmUpperThreshold": 70,
+  "pwmBoostValue": 100,
+  "pwmTransitionValue": 35,
+  "pwmLowerThreshold": 20,
+  "pwmUpperThreshold": 100,
   "watchdog": {
     "sysfsPath": "/run/devmap/watchdogs/FAN_WATCHDOG",
     "value": 0
@@ -22,89 +22,43 @@
       },
       "pwmCalcType": "SENSOR_PWM_CALC_TYPE_INCREMENTAL_PID",
       "pidSetting": {
-        "kp": -4,
-        "ki": -0.06,
+        "kp": 2,
+        "ki": 0.6,
         "kd": 0,
-        "setPoint": 97.0,
-        "posHysteresis": 0.0,
-        "negHysteresis": 8.0
-      }
-    },
-    {
-      "sensorName": "PIC_T_U13_INLET_LM75_2_TEMP",
-      "access": {
-        "accessType": "ACCESS_TYPE_THRIFT"
-      },
-      "pwmCalcType": "SENSOR_PWM_CALC_TYPE_FOUR_LINEAR_TABLE",
-      "normalUpTable": {
-        "30": 50,
-        "35": 60,
-        "37": 65,
-        "42": 70
-      },
-      "normalDownTable": {
-        "28": 50,
-        "33": 60,
-        "35": 65,
-        "40": 70
-      },
-      "failUpTable": {
-        "30": 55,
-        "35": 65,
-        "37": 70,
-        "42": 75
-      },
-      "failDownTable": {
-        "28": 55,
-        "33": 65,
-        "35": 70,
-        "40": 75
+        "setPoint": 90.0,
+        "posHysteresis": 3.0,
+        "negHysteresis": 3.0
       }
     },
     {
-      "sensorName": "PIC_B_U12_INLET_LM75_1_TEMP",
+      "sensorName": "PIC_T_U12_INLET_LM75_1_TEMP",
       "access": {
         "accessType": "ACCESS_TYPE_THRIFT"
       },
       "pwmCalcType": "SENSOR_PWM_CALC_TYPE_FOUR_LINEAR_TABLE",
       "normalUpTable": {
-        "30": 50,
-        "35": 60,
-        "37": 65,
-        "42": 70
+        "43": 30,
+        "44": 35,
+        "47": 40,
+        "52": 50
       },
       "normalDownTable": {
-        "28": 50,
-        "33": 60,
-        "35": 65,
-        "40": 70
+        "55": 50,
+        "54": 40,
+        "49": 35,
+        "46": 30
       },
       "failUpTable": {
-        "30": 55,
-        "35": 65,
-        "37": 70,
-        "42": 75
+        "43": 40,
+        "44": 45,
+        "47": 50,
+        "52": 60
       },
       "failDownTable": {
-        "28": 55,
-        "33": 65,
-        "35": 70,
-        "40": 75
-      }
-    },
-    {
-      "sensorName": "MCB_POWER_BRICK3_TEMP",
-      "access": {
-        "accessType": "ACCESS_TYPE_THRIFT"
-      },
-      "pwmCalcType": "SENSOR_PWM_CALC_TYPE_INCREMENTAL_PID",
-      "pidSetting": {
-        "kp": -8,
-        "ki": -0.06,
-        "kd": 0,
-        "setPoint": 105.0,
-        "posHysteresis": 0.0,
-        "negHysteresis": 3.0
+        "55": 60,
+        "54": 50,
+        "49": 45,
+        "46": 40
       }
     }
   ],
@@ -115,7 +69,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm1",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan1_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -126,7 +80,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm1",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan1_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -137,7 +91,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm2",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan2_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -148,7 +102,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm2",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan2_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -159,7 +113,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm3",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan3_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -170,7 +124,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm3",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan3_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -181,7 +135,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm4",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan4_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -192,7 +146,7 @@
       "pwmSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/pwm4",
       "presenceSysfsPath": "/run/devmap/sensors/MCB_FAN_CPLD/fan4_present",
       "pwmMin": 0,
-      "pwmMax": 40,
+      "pwmMax": 64,
       "fanPresentVal": 1,
       "fanMissingVal": 0,
       "rpmMin": 1500
@@ -204,9 +158,7 @@
       "zoneName": "zone1",
       "sensorNames": [
         "CPU_UNCORE_TEMP",
-        "PIC_T_U13_INLET_LM75_2_TEMP",
-        "PIC_B_U12_INLET_LM75_1_TEMP",
-        "MCB_POWER_BRICK3_TEMP"
+        "PIC_T_U12_INLET_LM75_1_TEMP"
       ],
       "fanNames": [
         "FAN_1_F",