Skip to content

Commit 8b89ac9

Browse files
JakobDegenfacebook-github-bot
authored andcommitted
third party: Upgrade rustc_hash
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
1 parent 2b3b02d commit 8b89ac9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ ref-cast = "1.0.0"
248248
regex = "1.5.4"
249249
relative-path = { version = "1.7.0", features = ["serde"] }
250250
rusqlite = { version = "0.29.0", features = ["bundled"] }
251-
rustc-hash = { version = "1.1" }
251+
rustc-hash = { version = "2.1" }
252252
rustls = "0.21.5"
253253
rustls-native-certs = { package = "rustls-native-certs", version = "0.6.2" }
254254
rustls-pemfile = { package = "rustls-pemfile", version = "1.0.0" }

shim/third-party/rust/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ regex = "1.5.4"
171171
relative-path = { version = "1.7.0", features = ["serde"] }
172172
ring = "=0.17.5" # Upgrading this is possible, but a pain, so we don't want to pick up every new minor version
173173
rusqlite = { version = "0.29.0", features = ["bundled"] }
174-
rustc-hash = "1.1.0"
174+
rustc-hash = "2.1.0"
175175
rustls = "0.21.0"
176176
rustls-native-certs = { package = "rustls-native-certs", version = "0.6.2" }
177177
rustls-pemfile = { package = "rustls-pemfile", version = "1.0.0" }

0 commit comments

Comments
 (0)