Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Change color for keywords and types #2

Open
jahirfiquitiva opened this issue Sep 4, 2022 · 14 comments
Open

[Request] Change color for keywords and types #2

jahirfiquitiva opened this issue Sep 4, 2022 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@jahirfiquitiva
Copy link

Hey, I wanted to ask if it's possible to change the colors used for const and types, as it's close to the green for class names which makes it a bit confusing.

Maybe the Pink or Fuchsia colors could fit the palette plus make those texts more distinguishable.

Thanks!

Shot 2022-09-04 at 13 54 22@2x

Even the preview image has this "issue"
Dark theme preview image

@fabian-hiller
Copy link
Owner

Thank you for your feedback! I am aware of the slight color difference. Personally, it hasn't bothered me so far. I will take a look at it with Fuchsia in the coming days.

@jahirfiquitiva
Copy link
Author

@fabian-hiller yeah, it isn't that bad, I just think it would be good to make the difference more noticeable 😅

@fabian-hiller
Copy link
Owner

I tested it with the color Fuchsia . For my taste, it ruins the overall look. Therefore, I would like to stay with the previous color for now.

@jahirfiquitiva
Copy link
Author

@fabian-hiller Any chance of having it as a variant? 🙏 😅

@fabian-hiller
Copy link
Owner

Yes, can you think of a suitable name?

@jahirfiquitiva
Copy link
Author

jahirfiquitiva commented Sep 13, 2022

@fabian-hiller what do you think about Pop? 🤔

@fabian-hiller
Copy link
Owner

This could work. In the long term, I prefer to have one or at most two variants of Dark and Light again, which correspond to my ideas. So it might be a good idea for you to fork the project and create your own theme out of it. On YouTube you can find videos about it. Have a great start to the week!

@BaiJiang007
Copy link

It's difficult to distinguish keywords and texts😭️

@fabian-hiller fabian-hiller self-assigned this Jun 25, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Jun 25, 2024
@fabian-hiller
Copy link
Owner

Can you send me a screenshot and highlight the text you would change the color of? Do you have a color recommendation?

@jahirfiquitiva
Copy link
Author

jahirfiquitiva commented Jun 25, 2024

@fabian-hiller

I think we mean these texts:
Image 188329117

The colors shades are really similar.

Here are some color suggestions that can be used for one of those (maybe the const keywords) for the different themes

Light Light+ Dark
#5f27cd #341f97 #ff9ff3
#786fa6 #574b90 #f8a5c2
#6c5ce7 #4C40A2 #B5AFFE
#5851DA #4834d4 #ED9AFE

@BaiJiang007
Copy link

image
When I use these variables, I cannot determine by color whether they have been declared, as they are all white like texts. This creates a significant usage burden

@fabian-hiller
Copy link
Owner

@jahirfiquitiva I am still not quite sure what you mean. Do you think the color of const and fetchSelfFeed are too similar?

@BaiJiang007 what color should it be? Blue? Can you create a PR?

@jahirfiquitiva
Copy link
Author

@fabian-hiller yes, the colors of const and fetchSelfFeed are too similar

@fabian-hiller
Copy link
Owner

Thanks for your feedback. Personally it doesn't bother me and at the moment I don't have time to work on it as I'm focused on Valibot. But feel free to fork and customize this theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants