-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React]: Preact Signals Dependency Update #188
Comments
Thank you for the info. I will investigate v2 in the next days and publish a new version. |
What happens if you ignore the peer dependency warning? Does Modular Forms still work as expected in development and production mode? |
I think a babel plugin is needed to get v2 working correctly. https://github.com/preactjs/signals/tree/main/packages/react#babel-transform |
Does Modular Forms still work as expected if you ignore the peer dependency warning? I am asking to find out if this is only necessary for end users. |
It didn't work for me. For example |
After you added the Bable plugin? |
Yeah added babel plugin to vite config inside the react plugin and couldn't make it work fastly. But I had not that much time to debug it. |
Ok. Feel free to add the Bable plugin to this repo in |
I updated the
However, the React Playground seems to be working fine. I don't see a problem with field errors. |
Cannot confirm this @awhitford. When passing When using v1.3.8 it works as expected: |
I will check and merge PR #191 tomorrow or in the next few days. |
I am using preact signals in my react app und currently using v2. This lib uses v1.
It would be great if @preact/signals could be upgraded to v2.
The text was updated successfully, but these errors were encountered: