build: apply language based on folder. #1975
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bjohansebas
changed the title
bjohansebas
force-pushed
the
i18n-better-second-try
branch
from
db232b4 to
ca68038
Compare
|
It seems everything is working fine, @expressjs/docs-wg please review it. |
bjohansebas
force-pushed
the
i18n-better-second-try
branch
from
ca68038 to
67e73ae
Compare
| @@ -16,7 +16,7 @@ help: ## This help | |||
|
|
|||
| serve: ## Local server | |||
| @echo "${BLUE}Starting expressjs.com at http://localhost:4000${RESET}" | |||
| docker run -p 4000:4000 -p 35729:35729 -v $(DIR):/usr/src/app expressjs.com bundle exec jekyll serve --host 0.0.0.0 --incremental | |||
| docker run -p 4000:4000 -p 35729:35729 -v $(DIR):/usr/src/app expressjs.com bundle exec jekyll serve --host 0.0.0.0 | |||
There was a problem hiding this comment.
There is a bug where dynamic texts are not loading correctly, so I'm going to remove this, since that fixes it.
I'll do it in another PR later, updating more information about Crowdin and all of that. |
Need to how |
see https://jekyllrb.com/docs/configuration/front-matter-defaults/ |
|
You can remove CSS changes from this PR. It got fixed in #1978. Since we are changing website build process in current PR. It is better to keep it separate. Also that is CSS issue, nothing to do with build changes. |
|
The 404 files can't be translated, which is why they are not uploaded, since Jekyll only serves the root 404 page. Edit: Or at least that’s what I remember happening when the 404 page was integrated. |
|
@ShubhamOulkar Thank you for the help. |
closes #1934
This PR updates how language metadata is applied to files in the site. Instead of using the
lang:front matter variable within individual files, the configuration now applies language settings based on file paths using Jekyll’s_config.yml scope and valuesfunctionality.