chore: refactor footer and header icons #1962
Open
+192
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ShubhamOulkar
added
the
maintenance
ShubhamOulkar
commented
Jul 5, 2025
ShubhamOulkar
commented
Jul 5, 2025
9 tasks
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
apply fill=currentColor on gihub and X icons Co-authored-by: Sebastian Beltran [email protected]
…pressjs.com into refactor-footer
ShubhamOulkar
force-pushed
the
refactor-footer
branch
from
13a5c86 to
ad3166a
Compare
|
Hi @bjohansebas, Can you review this? I want to land this early as possible.🙏 |
bjohansebas
reviewed
Jul 19, 2025
Comment on lines
+1
to
+4
| <!-- | ||
| Made by ShubhamOulkar: https://github.com/ShubhamOulkar/svg-icons | ||
| License: MIT | ||
| --> |
There was a problem hiding this comment.
I have to ping other members about this header, since it’s the first time I’ve seen it (apart from files that clearly come from a company). While it seems like you wrote it, I need to confirm with another member that it’s okay
There was a problem hiding this comment.
Yes, 3 simple icons.
There was a problem hiding this comment.
This might need to be on hold until a TC member confirms that it’s okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--box-fgfor theme toggle button.dark-mode