Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classNameHidden and classNameVisible not working when using Preact #351

Open
andreademasi opened this issue Mar 12, 2021 · 1 comment
Open

Comments

@andreademasi
Copy link

  • pure-react-carousel version: 1.27.6
  • react version: ^16.12.0
  • browser used: Google Chrome
  • node version: 12.13.1

What you did:

Tried setting custom classNameHidden and classNameVisible while using preact and Gatsby

What happened:

After using Preact, css classes weren't applied anymore on slide change

Reproduction:

https://github.com/andreademasi/pure-react-carousel-preact-bug

Try removing gatsby-plugin-preact from gatsby-config.js and the issue disappears

Suggested solution:

The library might be in conflict with preact, needs further investigation

@Conor-Hinchee
Copy link
Collaborator

Hey @andreademasi, I have been reviewing this issue and I have had some trouble determining the root cause. What I have been able to find out is that our Slide components are not receiving the updated state from withStore when using Preact. I think this StackOverflow discussion might be referencing the underlying issues. Do you have any other thoughts or suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants