Make RCTCxxBridge not care about the actual protocol implemented, only the method used

sjchmiela · sjchmiela · commit a81120e6463f · 2020-08-25T11:07:58.000+02:00
diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm
@@ -334,7 +334,7 @@ - (void)start
   // Prepare executor factory (shared_ptr for copy into block)
   std::shared_ptr<JSExecutorFactory> executorFactory;
   if (!self.executorClass) {
-    if ([self.delegate conformsToProtocol:@protocol(RCTCxxBridgeDelegate)]) {
+    if ([self.delegate respondsToSelector:@selector(jsExecutorFactoryForBridge:)]) {
       id<RCTCxxBridgeDelegate> cxxDelegate = (id<RCTCxxBridgeDelegate>)self.delegate;
       executorFactory = std::make_shared<JSCExecutorFactory>(*reinterpret_cast<JSCExecutorFactory *>([cxxDelegate jsExecutorFactoryForBridge:self]));
     }

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ - (void)start`
`334`	`334`	`// Prepare executor factory (shared_ptr for copy into block)`
`335`	`335`	`std::shared_ptr<JSExecutorFactory> executorFactory;`
`336`	`336`	`if (!self.executorClass) {`
`337`		`- if ([self.delegate conformsToProtocol:@protocol(RCTCxxBridgeDelegate)]) {`
	`337`	`+ if ([self.delegate respondsToSelector:@selector(jsExecutorFactoryForBridge:)]) {`
`338`	`338`	`id<RCTCxxBridgeDelegate> cxxDelegate = (id<RCTCxxBridgeDelegate>)self.delegate;`
`339`	`339`	`executorFactory = std::make_shared<JSCExecutorFactory>(reinterpret_cast<JSCExecutorFactory >([cxxDelegate jsExecutorFactoryForBridge:self]));`
`340`	`340`	`}`