Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting the expo prebuild workflow #36

Open
mikehostetler opened this issue Jan 19, 2022 · 1 comment
Open

Supporting the expo prebuild workflow #36

mikehostetler opened this issue Jan 19, 2022 · 1 comment

Comments

@mikehostetler
Copy link

Topic and scope of discussion

How would you summarise and scope the issue?

I've upgraded to Expo SDK 44 and have converted all of my changes inside the /ios and /android folders of my Expo Bare project over to using config plugins. I do commit my /ios and /android folders to source, but I only make changes to them using the new expo prebuild command.

My release workflow is:

// Increment a patch version
% npx standard-version

// Undo standard version's commit and delete the GIT tag 
% git reset --soft HEAD^
% git tag -d $TAG

// Re-run rebuild, carrying the versions in app.json into native code
% expo prebuild

// Re-stage latest GIT changes
% git add ...
% git commit

% git tag $TAG
% git push --follow-tags origin master

Motivation

Why should we have this discussion?

  1. Thoughts on adding a flag to standard-version that skips the commit step, so I don't have to undo it?
  2. How do we want to take expo prebuild into account? Should I use native bumpers, or continue using prebuild?

Additional context

Can you further explain the purpose of this discussion? E.g., screenshots or real-world examples.

See release workflow example above

@mitramejia
Copy link

Maybe you could use standard-libary config to skip the commit step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants