Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused name field in CIRType protobuf message #11

Open
DanielELog opened this issue Jan 19, 2025 · 0 comments
Open

Unused name field in CIRType protobuf message #11

DanielELog opened this issue Jan 19, 2025 · 0 comments

Comments

@DanielELog
Copy link
Collaborator

type.proto defines the field as a string. However, the implementation of serializeType inside Serializer.cpp never even initializes it. nameStr is explicitly written to a CIRTypeID instead, and CIRStructType has a separate name field attached.

Does it have a use or should it be removed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielELog