-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trace-based slicing implementation #1214
Comments
@JosephBond Given this task, it might not make sense to spend time diagnosing that graph vs. trace discrepancy for #1197. Perhaps a better strategy is to turn our v0.7.3 tag (the version we submitted to ESOP) into a branch (branches are similar to tags but support revisions and can be “protected” using rules) and then push ahead with removing traces as a precursor to finishing #1197. We can then use |
@rolyp whilst I would agree, the issue I raised in the slack channel remains, since the issue is not just that the trace and graph semantics don't agree, it's that |
Ah ok, I read your comment as suggesting that the test failure was due to the selection information being different. But if the graph semantics also somehow calculates the wrong value then yes that’s not something we can avoid having to fix. |
For further clarification: the graph semantics seems to compute the correct output value, it just computes the wrong selection information on that output value when running |
Ok to summarise our understanding so far, one likely problem with the idea of removing the trace-based implementation as a precursor task is that we will need to migrate the round-tripping test to the graph implementation, which will then fail (on our current understanding of the problem). An alternative suggestion then is to demote the |
Once the ESOP 2025 artifact is submitted we can commit to the graph-based implementation and remove
Trace
,Eval
,EvalBwd
, etc.See also:
The text was updated successfully, but these errors were encountered: