Skip to content

CRUD for Questionnaire #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
21Tulasi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CRUD for Questionnaire #246

21Tulasi wants to merge 4 commits into from

Conversation

@21Tulasi
Copy link

@21Tulasi 21Tulasi commented Dec 8, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

2 Warnings
⚠️ Schema changes detected without a corresponding DB migration.
⚠️ RSpec tests seem shallow (single it blocks or no context). Consider improving test structure.

Generated by 🚫 Danger

efg
efg reviewed Dec 23, 2025
View reviewed changes
Copy link
Member

@efg efg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

app/controllers/question_types_controller.rb Outdated
@@ -0,0 +1,7 @@
class QuestionTypesController < ApplicationController
Copy link
Member

@efg efg Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ItemTypesController

app/models/question_type.rb Outdated
@@ -0,0 +1,7 @@
class QuestionType < ApplicationRecord
Copy link
Member

@efg efg Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ItemType

app/models/question_type.rb Outdated
validates :name, presence: true, uniqueness: true

# Associations (if any later)
# has_many :questionnaires, foreign_key: :questionnaire_type, primary_key: :name
Copy link
Member

@efg efg Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has_many: consider replacing by belongs_to:

app/models/questionnaire.rb
end

# Check_for_question_associations checks if questionnaire has associated questions or not
# Check_for_question_associations checks if questionnaire has associated items or not
Copy link
Member

@efg efg Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_for_item_associations

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/item_spec.rb:60 # Item validations is not valid without a questionnaire

Failing Controller Test Cases:
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:191 # questionnaires /questionnaires/{id} put not found returns a 404 response
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:204 # questionnaires /questionnaires/{id} put unprocessable entity returns a 422 response
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:242 # questionnaires /questionnaires/{id} patch not found returns a 404 response
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:255 # questionnaires /questionnaires/{id} patch unprocessable entity returns a 422 response

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

🚨 RSpec Tests Report

Failing Controller Test Cases:
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:191 # questionnaires /questionnaires/{id} put not found returns a 404 response
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:204 # questionnaires /questionnaires/{id} put unprocessable entity returns a 422 response
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:242 # questionnaires /questionnaires/{id} patch not found returns a 404 response
rspec ./spec/requests/api/v1/questionnaires_controller_spec.rb:255 # questionnaires /questionnaires/{id} patch unprocessable entity returns a 422 response

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

🚨 RSpec Tests Report

All tests passed.

@vihar2712 vihar2712 self-requested a review January 21, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efg efg efg left review comments

@vihar2712 vihar2712 Awaiting requested review from vihar2712

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@21Tulasi @efg @tulasi210900-cpu