Fix output argument not being used #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ErikSchierboom opened this issue Nov 17, 2020 · 0 comments · Fixed by #19

Assignees

Labels

bug

Member

ErikSchierboom commented Nov 17, 2020

In this PR, support for input and output dir arguments was added. This does not completely work though, for the following reason:

run.sh does not pass three arguments: https://github.com/exercism/python-analyzer/blob/master/bin/run.sh#L6
The Exercise.factory function is called with three arguments (https://github.com/exercism/python-analyzer/blob/master/bin/run.py#L60), but it only takes two (https://github.com/exercism/python-analyzer/blob/master/lib/common/exercise.py#L73) (looks like the first argument is ignored).

The text was updated successfully, but these errors were encountered:

cmccandless added the bug label

BethanyG self-assigned this

BethanyG linked a pull request

that will close this issue

Fix for Issue 18: Output Arguments not used #19

Merged

BethanyG closed this as completed in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment