Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #10

Open
ringsaturn opened this issue Jul 20, 2022 · 1 comment
Open

Performance issues #10

ringsaturn opened this issue Jul 20, 2022 · 1 comment

Comments

@ringsaturn
Copy link
Contributor

ringsaturn commented Jul 20, 2022

Hi,

I wrote a package https://github.com/ringsaturn/tzf and add a benchmark page compard with this repo https://github.com/evanoberholster/timezoneLookup .

Benchmark shows that timezoneLookup which use RTree is slower 20 times compared with tzf which only use point in polygon search algo from https://github.com/tidwall/geojson

The performance seems comfusing because RTree should be faster, is there anything i missed in the benchmark code?

Benchmark repo https://github.com/ringsaturn/tz-benchmark

Bencmark pages https://ringsaturn.github.io/tz-benchmark/

@evanoberholster
Copy link
Owner

Hi,

Thanks for bringing this up. I will have to look a little closer at the code to see if I can find a reason.

I would assume that being backed by a byte array instead of PB and having an Rtree make it faster.

If you find something that might be the culprit, pleas let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants