Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some typo on the driver docs #174

Open
a1aw opened this issue Oct 12, 2016 · 3 comments
Open

Some typo on the driver docs #174

a1aw opened this issue Oct 12, 2016 · 3 comments

Comments

@a1aw
Copy link

a1aw commented Oct 12, 2016

Hi,

I found out some typo in the following document: http://www.ev3dev.org/docs/sensors/hitechnic-nxt-color-sensor/ , whereas vendor_id would be HiTechnic instead of HiTechnc.

I am not quite sure about it, but I think it is HiTechnic

Regards,
mob41

@ddemidov
Copy link
Member

HiTechnc is consistently used as a vendor_id throughout this file (it is used to generate the page you linked): https://github.com/ev3dev/lego-linux-drivers/blob/master/sensors/nxt_i2c_sensor_defs.c. So this could be the intended value.

@ddemidov
Copy link
Member

Also, vendor_id is defined as char[NXT_I2C_ID_STR_LEN + 1], where NXT_I2C_ID_STR_LEN is 8. So HiTechnic simply does not fit into vendor_id

@a1aw
Copy link
Author

a1aw commented Oct 18, 2016

Just a suggestion: Can this be told at the docs? So the users won't be confused with HiTechnc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants