Skip to content

Commit 7a87a82

Browse files
committed
doc: use new .IsTTY for linter
Signed-off-by: Yves Brissaud <[email protected]>
1 parent a2d5f6a commit 7a87a82

File tree

2 files changed

+31
-28
lines changed

2 files changed

+31
-28
lines changed

examples/go/runx.yaml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,16 @@ actions:
88
gocache: go env GOCACHE
99
cmd: >
1010
--rm
11-
-v {{sh "pwd"}}:/app
12-
-v {{sh "gopath"}}/pkg:/go/pkg
13-
-v {{sh "gocache"}}:/cache/go
14-
-e GOFLAGS=-buildvcs=false
15-
-e GOCACHE=/cache/go
16-
-e GOLANGCI_LINT_CACHE=/cache/go
17-
-w /app
18-
golangci/golangci-lint
19-
golangci-lint run -v --timeout 5m
11+
{{if .IsTTY}}-t{{end}}
12+
-v {{sh "pwd"}}:/app
13+
-v {{sh "gopath"}}/pkg:/go/pkg
14+
-v {{sh "gocache"}}:/cache/go
15+
-e GOFLAGS=-buildvcs=false
16+
-e GOCACHE=/cache/go
17+
-e GOLANGCI_LINT_CACHE=/cache/go
18+
-w /app
19+
{{.Ref}}
20+
golangci-lint run --timeout 5m
2021
2122
- id: build
2223
type: build

examples/golangci/runx.yaml

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@ actions:
99
gocache: go env GOCACHE
1010
cmd: >
1111
--rm
12-
-v {{sh "pwd"}}:/app
13-
-v {{sh "gopath"}}/pkg:/go/pkg
14-
-v {{sh "gocache"}}:/cache/go
15-
-e GOFLAGS=-buildvcs=false
16-
-e GOCACHE=/cache/go
17-
-e GOLANGCI_LINT_CACHE=/cache/go
18-
-w /app
19-
{{.Ref}}
20-
golangci-lint run -v --timeout 5m
12+
{{if .IsTTY}}-t{{end}}
13+
-v {{sh "pwd"}}:/app
14+
-v {{sh "gopath"}}/pkg:/go/pkg
15+
-v {{sh "gocache"}}:/cache/go
16+
-e GOFLAGS=-buildvcs=false
17+
-e GOCACHE=/cache/go
18+
-e GOLANGCI_LINT_CACHE=/cache/go
19+
-w /app
20+
{{.Ref}}
21+
golangci-lint run --timeout 5m
2122
2223
- id: with-config
2324
desc: Run golangci-lint with a specific config file
@@ -32,13 +33,14 @@ actions:
3233
required: true
3334
cmd: >
3435
--rm
35-
-v {{sh "pwd"}}:/app
36-
-v {{sh "gopath"}}/pkg:/go/pkg
37-
-v {{sh "gocache"}}:/cache/go
38-
--mount type=bind,source={{sh "pwd"}}/{{opt "config"}},target=/.golangci.yml
39-
-e GOFLAGS=-buildvcs=false
40-
-e GOCACHE=/cache/go
41-
-e GOLANGCI_LINT_CACHE=/cache/go
42-
-w /app
43-
{{.Ref}}
44-
golangci-lint run -v -c /.golangci.yml --timeout 5m
36+
{{if .IsTTY}}-t{{end}}
37+
-v {{sh "pwd"}}:/app
38+
-v {{sh "gopath"}}/pkg:/go/pkg
39+
-v {{sh "gocache"}}:/cache/go
40+
--mount type=bind,source={{sh "pwd"}}/{{opt "config"}},target=/.golangci.yml
41+
-e GOFLAGS=-buildvcs=false
42+
-e GOCACHE=/cache/go
43+
-e GOLANGCI_LINT_CACHE=/cache/go
44+
-w /app
45+
{{.Ref}}
46+
golangci-lint run -c /.golangci.yml --timeout 5m

0 commit comments

Comments
 (0)