Add flag to turn off ABI validation #3536
Comments
|
On doing the same operation, 7.5.0 is faster. In my example: 7.5.0: 4.154691696166992 seconds 7.6.0: 48.58938956260681 seconds 7.5.0 is pretty much faster |
3 tasks
yabirgb
added a commit
to yabirgb/rotki
that referenced
this issue
Dec 9, 2024
7.6.0 seems to have a performance issue related to abi validation ethereum/web3.py#3536 7.5.0 is fine. I created an issue that describes how it hits us in one place ethereum/web3.py#3553 When a patch gets released we can check again to update
LefterisJP
pushed a commit
to rotki/rotki
that referenced
this issue
Dec 9, 2024
7.6.0 seems to have a performance issue related to abi validation ethereum/web3.py#3536 7.5.0 is fine. I created an issue that describes how it hits us in one place ethereum/web3.py#3553 When a patch gets released we can check again to update
|
@reedsa I'm for closing this |
|
Yep, I think we are good to close. Thanks @reedsa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What feature should we add?
ABI Validation here: https://github.com/ethereum/web3.py/blob/main/web3/utils/abi.py#L605 takes a long time (90s) for lots (~800) of contracts that get loaded in up front. See conversation in the Discord that starts here It would be nice to be able to turn that off for advanced use cases. One API proposed is something like
w3.eth.contract(address=addr, abi=abi, validate_abi=False). Extra credit for beefing up benchmarking at the same time.The text was updated successfully, but these errors were encountered: