Address comments on PR #2819; add newsfragment

fselmo · fselmo · commit b68b64e56f8f · 2023-02-22T13:11:01.000-07:00
diff --git a/newsfragments/2819.breaking.rst b/newsfragments/2819.breaking.rst
@@ -0,0 +1 @@
+Use ``AsyncWeb3`` class and preserve typing for the async api calls.
diff --git a/web3/contract/base_contract.py b/web3/contract/base_contract.py
@@ -107,7 +107,6 @@
     ABIEvent,
     ABIFunction,
     BlockIdentifier,
-    CallOverride,
     EventData,
     FilterParams,
     FunctionIdentifier,
diff --git a/web3/contract/utils.py b/web3/contract/utils.py
@@ -59,8 +59,6 @@
         AsyncWeb3,
         Web3,
     )
-    from web3.contract.async_contract import AsyncContractFunction  # noqa: F401
-    from web3.contract.contract import ContractFunction  # noqa: F401
 
 ACCEPTABLE_EMPTY_STRINGS = ["0x", b"0x", "", b""]
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Use ``AsyncWeb3`` class and preserve typing for the async api calls.
Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,6 @@`
`59`	`59`	`AsyncWeb3,`
`60`	`60`	`Web3,`
`61`	`61`	`)`
`62`		`- from web3.contract.async_contract import AsyncContractFunction # noqa: F401`
`63`		`- from web3.contract.contract import ContractFunction # noqa: F401`
`64`	`62`
`65`	`63`	`ACCEPTABLE_EMPTY_STRINGS = ["0x", b"0x", "", b""]`
`66`	`64`