Skip to content
This repository was archived by the owner on May 23, 2023. It is now read-only.

ecrecover is way too slow #396

Closed
heikoheiko opened this issue Jul 18, 2016 · 1 comment
Closed

ecrecover is way too slow #396

heikoheiko opened this issue Jul 18, 2016 · 1 comment
Assignees

Comments

@heikoheiko
Copy link
Member

the current implementation introduced in 461a88a which uses libsecp256k1 is for some reason very slow.

The one used before that commit is x40 faster.

{'add_block': {'calls': 1000, 'total': 37.05270528793335},
 'apply_transaction': {'calls': 2321, 'total': 34.751814126968384},
 'apply_tx.ecrecover': {'calls': 2321, 'total': 21.537762880325317},
 'apply_tx.ecrecover_raw': {'calls': 2321, 'total': 0.592186450958252}}

The current broken ecrecover accounts for ~2/3 of the tx validation time .

@ofek
Copy link
Contributor

ofek commented Aug 17, 2017

@joeykrug @heikoheiko @ulope Fixed in #777

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants