✨ feat(tests): EIP-7928 test_bal_2930_slot_listed_and_unlisted_reads

Author: raxhvl

tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py

@@ -403,3 +403,60 @@ def test_bal_2930_slot_listed_and_unlisted_writes(
             storage_writer: Account(storage={0x01: 0x42, 0x02: 0x43}),
         },
     )
+
+
+@pytest.mark.valid_from("Amsterdam")
+def test_bal_2930_slot_listed_and_unlisted_reads(
+    pre: Alloc,
+    blockchain_test: BlockchainTestFiller,
+    fork,
+):
+    """Ensure BAL includes storage reads regardless of access list presence."""
+    alice = pre.fund_eoa()
+    storage_reader = pre.deploy_contract(
+        code=Op.SLOAD(0x01) + Op.SLOAD(0x02),
+        storage={0x01: 0x42, 0x02: 0x43},  # Pre-populate storage with values
+    )
+
+    # Access list only includes slot 0x01, but contract reads from both 0x01 and 0x02
+    access_list = AccessList(
+        address=storage_reader,
+        storage_keys=[Hash(0x01)],
+    )
+
+    intrinsic_gas_calculator = fork.transaction_intrinsic_cost_calculator()
+    gas_limit = (
+        intrinsic_gas_calculator(
+            calldata=b"",
+            contract_creation=False,
+            access_list=[access_list],
+        )
+        + 50000
+    )  # intrinsic + buffer for storage reads
+
+    tx = Transaction(
+        ty=1, sender=alice, to=storage_reader, gas_limit=gas_limit, access_list=[access_list]
+    )
+
+    block = Block(
+        txs=[tx],
+        expected_block_access_list=BlockAccessListExpectation(
+            account_expectations={
+                alice: BalAccountExpectation(
+                    nonce_changes=[BalNonceChange(tx_index=1, post_nonce=1)],
+                ),
+                storage_reader: BalAccountExpectation(
+                    storage_reads=[0x01, 0x02],
+                ),
+            }
+        ),
+    )
+
+    blockchain_test(
+        pre=pre,
+        blocks=[block],
+        post={
+            alice: Account(nonce=1),
+            storage_reader: Account(storage={0x01: 0x42, 0x02: 0x43}),
+        },
+    )

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md

@@ -9,7 +9,7 @@
 | `test_bal_code_changes` | Ensure BAL captures changes to account code | Alice deploys factory contract that creates new contract | BAL MUST include code changes for newly deployed contract | ✅ Completed |
 | `test_bal_2930_slot_listed_but_untouched` | Ensure BAL excludes listed but untouched storage slots        | Alice sends tx with EIP-2930 access list including `(PureCalculator, slot=0x01)`; PureCalculator executes pure arithmetic (adding two numbers) without touching slot `0x01` | BAL MUST NOT include any entry for PureCalculator's slot `0x01` because it doesn't access state | ✅ Completed |
 | `test_bal_2930_slot_listed_and_unlisted_writes`  | Ensure BAL includes storage writes regardless of access list presence | Alice sends tx with EIP-2930 access list including `(StorageWriter, slot=0x01)`; StorageWriter executes `SSTORE` to slots `0x01` and `0x02` | BAL MUST include `storage_changes` for StorageWriter's slots `0x01` and `0x02` | ✅ Completed |
-| `test_bal_2930_slot_listed_and_unlisted_reads` | Ensure BAL includes storage reads regardless of access list presence | Alice sends tx with EIP-2930 access list including `(Contract, slot=0x01)`; Contract executes `SLOAD` from slots `0x01` and `0x02` | BAL MUST include storage_access for Contract's slots `0x01` and `0x02` | 🟡 Planned |
+| `test_bal_2930_slot_listed_and_unlisted_reads` | Ensure BAL includes storage reads regardless of access list presence | Alice sends tx with EIP-2930 access list including `(StorageReader, slot=0x01)`; StorageReader executes `SLOAD` from slots `0x01` and `0x02` | BAL MUST include `storage_reads` for StorageReader's slots `0x01` and `0x02` | ✅ Completed |
 | `test_bal_7702_delegated_create`                 | BAL tracks EIP-7702 delegation indicator write and contract creation        | Alice sends a type-4 (7702) tx authorizing herself to delegate to `Deployer` code which executes `CREATE`                      | BAL MUST include for **Alice**: `code_changes` (delegation indicator), `nonce_changes` (increment from 7702 processing), and `balance_changes` (post-gas). For **Child**: `code_changes` (runtime bytecode) and `nonce_changes = 1`. | 🟡 Planned  |
 | `test_bal_self_transfer`                         | BAL handles self-transfers correctly                                        | Alice sends `1 ETH` to **Alice**                                                                                               | BAL MUST include **one** entry for Alice with `balance_changes` reflecting **gas only** (value cancels out) and a nonce change; Coinbase balance updated for fees; no separate recipient row.                                        | 🟡 Planned  |
 | `test_bal_system_contracts_2935_4788`            | BAL includes pre-exec system writes for parent hash & beacon root           | Build a block with `N` normal txs; 2935 & 4788 active                                                                          | BAL MUST include `HISTORY_STORAGE_ADDRESS` (EIP-2935) and `BEACON_ROOTS_ADDRESS` (EIP-4788) with `storage_changes` to ring-buffer slots; each write uses `tx_index = N` (system op).                                                 | 🟡 Planned  |