✨ feat(tests): test_bal_delegated_storage_reads

Author: raxhvl

tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists.py

@@ -567,11 +567,11 @@ def test_bal_delegated_storage_writes(
     alice = pre.fund_eoa()
 
     # TargetContract that writes 0x42 to slot 0x01
-    target_code = Op.SSTORE(0x01, 0x42) + Op.STOP
+    target_code = Op.SSTORE(0x01, 0x42)
     target_contract = pre.deploy_contract(code=target_code)
 
     # Oracle contract that uses delegated opcode to execute TargetContract's code
-    oracle_code = delegated_opcode(target_contract) + Op.STOP
+    oracle_code = delegated_opcode(target_contract)
     oracle_contract = pre.deploy_contract(code=oracle_code)
 
     tx = Transaction(
@@ -601,3 +601,55 @@ def test_bal_delegated_storage_writes(
     )
 
     blockchain_test(pre=pre, blocks=[block], post={})
+
+
+@pytest.mark.parametrize(
+    "delegated_opcode",
+    [
+        pytest.param(
+            lambda target_addr: Op.DELEGATECALL(50000, target_addr, 0, 0, 0, 0), id="delegatecall"
+        ),
+        pytest.param(
+            lambda target_addr: Op.CALLCODE(50000, target_addr, 0, 0, 0, 0, 0), id="callcode"
+        ),
+    ],
+)
+def test_bal_delegated_storage_reads(
+    pre: Alloc,
+    blockchain_test: BlockchainTestFiller,
+    delegated_opcode,
+):
+    """Ensure BAL captures delegated storage reads via DELEGATECALL and CALLCODE."""
+    alice = pre.fund_eoa()
+
+    # TargetContract that reads from slot 0x01
+    target_code = Op.SLOAD(0x01) + Op.STOP
+    target_contract = pre.deploy_contract(code=target_code)
+
+    # Oracle contract with storage slot 0x01 = 0x42,
+    # uses delegated opcode to execute TargetContract's code
+    oracle_code = delegated_opcode(target_contract)
+    oracle_contract = pre.deploy_contract(code=oracle_code, storage={0x01: 0x42})
+
+    tx = Transaction(
+        sender=alice,
+        to=oracle_contract,
+        gas_limit=1_000_000,
+    )
+
+    block = Block(
+        txs=[tx],
+        expected_block_access_list=BlockAccessListExpectation(
+            account_expectations={
+                alice: BalAccountExpectation(
+                    nonce_changes=[BalNonceChange(tx_index=1, post_nonce=1)],
+                ),
+                oracle_contract: BalAccountExpectation(
+                    storage_reads=[0x01],
+                ),
+                target_contract: BalAccountExpectation(),
+            }
+        ),
+    )
+
+    blockchain_test(pre=pre, blocks=[block], post={})

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md

@@ -13,6 +13,7 @@
 | `test_bal_call_with_value_transfer` | Ensure BAL captures balance changes from `CALL` opcode with value transfer | Alice calls `Oracle` contract (200 wei balance) which uses `CALL` opcode to transfer 100 wei to Bob (0 wei balance). | BAL MUST include Alice (nonce changes), Oracle (balance change to 100 wei), and Bob (balance change to 100 wei). | ✅ Completed |
 | `test_bal_callcode_with_value_transfer` | Ensure BAL captures balance changes from `CALLCODE` opcode with value transfer | Alice calls `Oracle` contract (200 wei balance) which uses `CALLCODE` opcode to execute `TargetContract`'s code with 100 wei value transfer to Bob (0 wei balance). | BAL MUST include Alice (nonce changes), `Oracle` (balance change to 100 wei), Bob (balance change to 100 wei), and `TargetContract` (empty changes). | ✅ Completed |
 | `test_bal_delegated_storage_writes` | Ensure BAL captures delegated storage writes via `DELEGATECALL` and `CALLCODE` | Alice calls `Oracle` contract which uses `DELEGATECALL`/`CALLCODE` to `TargetContract` that writes `0x42` to slot `0x01`. | BAL MUST include Alice (nonce changes), `Oracle` (storage changes for slot `0x01` = `0x42`), and `TargetContract` (empty changes). | ✅ Completed |
+| `test_bal_delegated_storage_reads` | Ensure BAL captures delegated storage reads via `DELEGATECALL` and `CALLCODE` | Alice calls `Oracle` contract (with slot `0x01` = `0x42`) which uses `DELEGATECALL`/`CALLCODE` to `TargetContract` that reads from slot `0x01`. | BAL MUST include Alice (nonce changes), `Oracle` (storage reads for slot `0x01`), and `TargetContract` (empty changes). | ✅ Completed |
 | `test_bal_2930_slot_listed_but_untouched` | Ensure 2930 access list alone doesn’t appear in BAL        | Include `(KV, S=0x01)` in tx’s EIP-2930 access list; tx executes code that does **no** `SLOAD`/`SSTORE` to `S` (e.g., pure arithmetic/log). | BAL **MUST NOT** contain any entry for `(KV, S)` — neither reads nor writes — because the slot wasn’t touched.                                                                                                    | 🟡 Planned |
 | `test_bal_2930_slot_listed_and_modified`  | Ensure BAL records writes only because the slot is touched | Same access list as above, but tx executes `SSTORE` to `S`.                                                                                 | BAL **MUST** include `storage_changes` for `(KV, S)` (and no separate read record for that slot if implementation deduplicates). Presence in the access list is irrelevant; inclusion is due to the actual write. | 🟡 Planned |
 | `test_bal_7702_delegated_create`                 | BAL tracks EIP-7702 delegation indicator write and contract creation        | Alice sends a type-4 (7702) tx authorizing herself to delegate to `Deployer` code which executes `CREATE`                      | BAL MUST include for **Alice**: `code_changes` (delegation indicator), `nonce_changes` (increment from 7702 processing), and `balance_changes` (post-gas). For **Child**: `code_changes` (runtime bytecode) and `nonce_changes = 1`. | 🟡 Planned  |