proper benchmarks

Author: chfast

test/precompiles_bench/precompiles_bench.cpp

@@ -32,7 +32,7 @@ constexpr auto analyze<PrecompileId::ecadd> = ecadd_analyze;
 template <>
 constexpr auto analyze<PrecompileId::ecmul> = ecmul_analyze;
 template <>
-[[maybe_unused]] constexpr auto analyze<PrecompileId::ecpairing> = ecpairing_analyze;
+constexpr auto analyze<PrecompileId::ecpairing> = ecpairing_analyze;
 
 template <PrecompileId>
 const inline std::array inputs{0};
@@ -185,57 +185,13 @@ BENCHMARK_TEMPLATE(precompile, PrecompileId::ecmul, libff);
 
 namespace bench_ecpairing
 {
+constexpr auto evmmax_cpp = ecpairing_execute;
+BENCHMARK_TEMPLATE(precompile, PrecompileId::ecpairing, evmmax_cpp);
 #ifdef EVMONE_PRECOMPILES_SILKPRE
 constexpr auto libff = silkpre_ecpairing_execute;
 BENCHMARK_TEMPLATE(precompile, PrecompileId::ecpairing, libff);
 #endif
 }  // namespace bench_ecpairing
-
-
-template <ExecuteFn Fn>
-void ecpairing(benchmark::State& state)
-{
-    const auto input = evmc::from_hex(
-        "105456a333e6d636854f987ea7bb713dfd0ae8371a72aea313ae0c32c0bf10160cf031d41b41557f3e7e3ba0c5"
-        "1bebe5da8e6ecd855ec50fc87efcdeac168bcc0476be093a6d2b4bbf907172049874af11e1b6267606e00804d3"
-        "ff0037ec57fd3010c68cb50161b7d1d96bb71edfec9880171954e56871abf3d93cc94d745fa114c059d74e5b6c"
-        "4ec14ae5864ebe23a71781d86c29fb8fb6cce94f70d3de7a2101b33461f39d9e887dbb100f170a2345dde3c07e"
-        "256d1dfa2b657ba5cd030427000000000000000000000000000000000000000000000000000000000000000100"
-        "000000000000000000000000000000000000000000000000000000000000021a2c3013d2ea92e13c800cde68ef"
-        "56a294b883f6ac35d25f587c09b1b3c635f7290158a80cd3d66530f74dc94c94adb88f5cdb481acca997b6e600"
-        "71f08a115f2f997f3dbd66a7afe07fe7862ce239edba9e05c5afff7f8a1259c9733b2dfbb929d1691530ca701b"
-        "4a106054688728c9972c8512e9789e9567aae23e302ccd75000000000000000000000000000000000000000000"
-        "000000000000000000000100000000000000000000000000000000000000000000000000000000000000020000"
-        "000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
-        "000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
-        "000000000000000000000000000000000000000000000000000000000000000000000000")
-                           .value();
-    uint8_t output[32];
-
-    const auto [gas_cost, max_output_size] =
-        evmone::state::ecpairing_analyze(input, EVMC_LATEST_STABLE_REVISION);
-    if (max_output_size > std::size(output))
-        return state.SkipWithError("too small output");
-
-    int64_t total_gas_used = 0;
-    for ([[maybe_unused]] auto _ : state)
-    {
-        const auto [status, _2] = Fn(input.data(), input.size(), output, std::size(output));
-        if (status != EVMC_SUCCESS) [[unlikely]]
-            return state.SkipWithError("invalid result");
-        total_gas_used += gas_cost;
-    }
-
-    using benchmark::Counter;
-    state.counters["gas_used"] = Counter(static_cast<double>(gas_cost));
-    state.counters["gas_rate"] = Counter(static_cast<double>(total_gas_used), Counter::kIsRate);
-}
-
-BENCHMARK_TEMPLATE(ecpairing, evmone::state::ecpairing_execute);
-#ifdef EVMONE_PRECOMPILES_SILKPRE
-BENCHMARK_TEMPLATE(ecpairing, evmone::state::silkpre_ecpairing_execute);
-#endif
-
 }  // namespace
 
 BENCHMARK_MAIN();