Skip to content

Commit ca32a27

Browse files
authored
chore(op-acceptance-tests): isthmus into base gate. (#17514)
As Isthmus is on Mainnet, we now move this gate into the 'base' gate which should work against all devnets.
1 parent 2841f11 commit ca32a27

File tree

3 files changed

+20
-27
lines changed

3 files changed

+20
-27
lines changed

op-acceptance-tests/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ just acceptance-test "" base
5454

5555
# Run against Kurtosis devnets (requires Docker + Kurtosis)
5656
just acceptance-test simple base
57-
just acceptance-test isthmus isthmus
5857
just acceptance-test interop interop
5958
```
6059

@@ -106,7 +105,7 @@ For integration testing against realistic networks:
106105

107106
1. **Automated approach** (rebuilds devnet each time):
108107
```bash
109-
just acceptance-test isthmus isthmus
108+
just acceptance-test interop interop
110109
```
111110

112111
2. **Manual approach** (once-off)

op-acceptance-tests/acceptance-tests.yaml

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,24 @@
77

88

99
gates:
10-
- id: conductor
11-
description: "Sanity/smoke acceptance tests for networks with conductors."
10+
- id: isthmus
11+
description: "Isthmus network tests."
1212
tests:
13-
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/base/conductor
13+
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus
14+
timeout: 6h
15+
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/operator_fee
16+
timeout: 6h
17+
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/withdrawal_root
18+
timeout: 20m
19+
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/erc20_bridge
20+
timeout: 10m
21+
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/pectra
1422
timeout: 10m
1523

1624
- id: base
1725
description: "Sanity/smoke acceptance tests for all networks."
26+
inherits:
27+
- isthmus
1828
tests:
1929
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/base
2030
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/base/deposit
@@ -28,20 +38,10 @@ gates:
2838
# timeout: 10m
2939
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/fjord
3040

31-
- id: isthmus
32-
inherits:
33-
- base
34-
description: "Isthmus network tests."
41+
- id: conductor
42+
description: "Sanity/smoke acceptance tests for networks with conductors."
3543
tests:
36-
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus
37-
timeout: 6h
38-
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/operator_fee
39-
timeout: 6h
40-
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/withdrawal_root
41-
timeout: 20m
42-
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/erc20_bridge
43-
timeout: 10m
44-
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/isthmus/pectra
44+
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/base/conductor
4545
timeout: 10m
4646

4747
- id: pre-interop
@@ -82,7 +82,7 @@ gates:
8282

8383
- id: flashblocks-with-isthmus
8484
inherits:
85-
- isthmus
85+
- base
8686
description: "Flashblocks network tests with Isthmus."
8787
tests:
8888
- package: github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/flashblocks

op-acceptance-tests/justfile

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@ ACCEPTOR_IMAGE := env_var_or_default("ACCEPTOR_IMAGE", DOCKER_REGISTRY + "/op-ac
88
default:
99
@just acceptance-test "" base
1010

11-
holocene:
12-
@just acceptance-test "" holocene
13-
14-
isthmus:
15-
@just acceptance-test "" isthmus
16-
1711
jovian:
1812
@just acceptance-test jovian jovian
1913

@@ -28,7 +22,7 @@ interop:
2822
# just acceptance-test "" "" # In-process gateless mode (all tests)
2923
# just acceptance-test "simple" base # External devnet with specific gate
3024
# just acceptance-test "simple" "" # External devnet gateless mode (all tests)
31-
acceptance-test devnet="" gate="holocene":
25+
acceptance-test devnet="" gate="base":
3226
#!/usr/bin/env bash
3327
set -euo pipefail
3428

@@ -132,7 +126,7 @@ acceptance-test devnet="" gate="holocene":
132126

133127

134128
# Run acceptance tests against a devnet using Docker (fallback if needed)
135-
acceptance-test-docker devnet="simple" gate="holocene":
129+
acceptance-test-docker devnet="simple" gate="base":
136130
#!/usr/bin/env bash
137131
set -euo pipefail
138132

0 commit comments

Comments
 (0)