cannon: Add go 1.25 tests (#18279)

* cannon: Add go 1.25 tests

* cannon: Use go 1.25.4 for tests.

Simplify and actually run the keccak tests.

Author: ajsutton

cannon/mipsevm/multithreaded/instrumented_test.go

@@ -13,6 +13,7 @@ import (
 
 	"github.com/ethereum/go-ethereum/log"
 	"github.com/stretchr/testify/require"
+	"golang.org/x/crypto/sha3"
 
 	"github.com/ethereum-optimism/optimism/cannon/mipsevm"
 	"github.com/ethereum-optimism/optimism/cannon/mipsevm/memory"
@@ -69,8 +70,36 @@ func TestInstrumentedState_Claim(t *testing.T) {
 	})
 }
 
+func TestInstrumentedState_Keccak(t *testing.T) {
+	runTestAcrossVms(t, "Keccak", func(t *testing.T, vmFactory VMFactory[*State], goTarget testutil.GoTarget) {
+		state, meta := testutil.LoadELFProgram(t, testutil.ProgramPath("keccak", goTarget), CreateInitialState)
+
+		var stdOutBuf, stdErrBuf bytes.Buffer
+		us := vmFactory(state, nil, io.MultiWriter(&stdOutBuf, os.Stdout), io.MultiWriter(&stdErrBuf, os.Stderr), testutil.CreateLogger(), meta)
+
+		for i := 0; i < 2000_000; i++ {
+			if us.GetState().GetExited() {
+				break
+			}
+			_, err := us.Step(false)
+			require.NoError(t, err)
+		}
+
+		require.True(t, state.GetExited(), "must complete program")
+		require.Equal(t, uint8(0), state.GetExitCode(), "exit with 0")
+
+		var result []byte
+		keccakState := sha3.NewLegacyKeccak256()
+		keccakState.Write([]byte{1, 2, 3})
+		result = keccakState.Sum(result)
+		expectedStdOut := fmt.Sprintf("keccak program. result=%x\n", result)
+		require.Equal(t, expectedStdOut, stdOutBuf.String(), "stdout")
+		require.Equal(t, "", stdErrBuf.String(), "stderr")
+	})
+}
+
 func TestInstrumentedState_Random(t *testing.T) {
-	state, meta := testutil.LoadELFProgram(t, testutil.ProgramPath("random", testutil.Go1_24), CreateInitialState)
+	state, meta := testutil.LoadELFProgram(t, testutil.ProgramPath("random", testutil.Go1_25), CreateInitialState)
 
 	var stdOutBuf, stdErrBuf bytes.Buffer
 	us := latestVm(state, nil, io.MultiWriter(&stdOutBuf, os.Stdout), io.MultiWriter(&stdErrBuf, os.Stderr), testutil.CreateLogger(), meta)
@@ -420,6 +449,7 @@ func runTestsAcrossVms[T any](t *testing.T, testNamer TestNamer[T], testCases []
 	variations := []VMVariations{
 		{name: "Go 1.23 VM", goTarget: testutil.Go1_23, features: mipsevm.FeatureToggles{}},
 		{name: "Go 1.24 VM", goTarget: testutil.Go1_24, features: allFeaturesEnabled()},
+		{name: "Go 1.25 VM", goTarget: testutil.Go1_25, features: allFeaturesEnabled()},
 	}
 
 	for _, testCase := range testCases {

cannon/mipsevm/tests/evm_common_test.go

@@ -992,7 +992,7 @@ func TestEVM_RandomProgram(t *testing.T) {
 			validator := testutil.NewEvmValidator(t, v.StateHashFn, v.Contracts)
 
 			var stdOutBuf, stdErrBuf bytes.Buffer
-			elfFile := testutil.ProgramPath("random", testutil.Go1_24)
+			elfFile := testutil.ProgramPath("random", testutil.Go1_25)
 			goVm := v.ElfVMFactory(t, elfFile, nil, io.MultiWriter(&stdOutBuf, os.Stdout), io.MultiWriter(&stdErrBuf, os.Stderr), testutil.CreateLogger())
 			state := goVm.GetState()
 

cannon/mipsevm/tests/helpers.go

@@ -91,7 +91,7 @@ func GetMipsVersionTestCases(t require.TestingT) []VersionedVMTestCase {
 			goTarget := testutil.Go1_23
 			features := versions.FeaturesForVersion(version)
 			if features.SupportWorkingSysGetRandom {
-				goTarget = testutil.Go1_24
+				goTarget = testutil.Go1_25
 			}
 			cases = append(cases, GetMultiThreadedTestCase(t, version, goTarget))
 		}

cannon/mipsevm/testutil/elf.go

@@ -15,6 +15,7 @@ type GoTarget string
 const (
 	Go1_23 GoTarget = "go-1-23"
 	Go1_24 GoTarget = "go-1-24"
+	Go1_25 GoTarget = "go-1-25"
 )
 
 func LoadELFProgram[T mipsevm.FPVMState](t require.TestingT, name string, initState program.CreateInitialFPVMState[T]) (T, *program.Metadata) {

cannon/testdata/Makefile

@@ -8,10 +8,15 @@ go1-24:
 	make -C ./go-1-24 elf
 .PHONY: go1-24
 
+go1-25:
+	make -C ./go-1-25 elf
+.PHONY: go1-25
+
 .PHONY: elf
-elf: go1-23 go1-24
+elf: go1-23 go1-24 go1-25
 
 .PHONY: clean
 clean:
 	make -C ./go-1-23 clean
 	make -C ./go-1-24 clean
+	make -C ./go-1-25 clean

cannon/testdata/go-1-23/keccak/go.mod

@@ -0,0 +1,11 @@
+module keccak
+
+go 1.23.0
+
+toolchain go1.23.8
+
+require golang.org/x/crypto v0.35.0
+
+require golang.org/x/sys v0.30.0 // indirect
+
+replace github.com/ethereum-optimism/optimism v0.0.0 => ./../../../..

cannon/testdata/go-1-23/keccak/go.sum

@@ -0,0 +1,4 @@
+golang.org/x/crypto v0.35.0 h1:b15kiHdrGCHrP6LvwaQ3c03kgNhhiMgvlhxHQhmg2Xs=
+golang.org/x/crypto v0.35.0/go.mod h1:dy7dXNW32cAb/6/PRuTNsix8T+vJAqvuIy5Bli/x0YQ=
+golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
+golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=

cannon/testdata/go-1-23/keccak/main.go

@@ -0,0 +1,16 @@
+package main
+
+import (
+	"fmt"
+
+	"golang.org/x/crypto/sha3"
+)
+
+func main() {
+	var result []byte
+	state := sha3.NewLegacyKeccak256()
+	state.Write([]byte{1, 2, 3})
+	result = state.Sum(result)
+
+	fmt.Printf("keccak program. result=%x\n", result)
+}

cannon/testdata/go-1-24/keccak/go.mod

@@ -0,0 +1,11 @@
+module keccak
+
+go 1.24
+
+toolchain go1.24.2
+
+require golang.org/x/crypto v0.35.0
+
+require golang.org/x/sys v0.30.0 // indirect
+
+replace github.com/ethereum-optimism/optimism v0.0.0 => ./../../../..

cannon/testdata/go-1-24/keccak/go.sum

@@ -0,0 +1,4 @@
+golang.org/x/crypto v0.35.0 h1:b15kiHdrGCHrP6LvwaQ3c03kgNhhiMgvlhxHQhmg2Xs=
+golang.org/x/crypto v0.35.0/go.mod h1:dy7dXNW32cAb/6/PRuTNsix8T+vJAqvuIy5Bli/x0YQ=
+golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
+golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=