Skip to content

Commit fe34c2c

Browse files
JohnMcLearclaude
andcommitted
ci(installer): run installer.ps1 under Windows PowerShell 5.1 too
Refs #8214. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0139nGyeFNACmifj6pRLSVRs
1 parent f95d67b commit fe34c2c

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/installer-test.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,16 @@ jobs:
111111
fi
112112
113113
installer-windows:
114-
name: end-to-end install (windows-latest)
114+
name: end-to-end install (windows-latest, ${{ matrix.shell }})
115115
runs-on: windows-latest
116+
strategy:
117+
fail-fast: false
118+
matrix:
119+
# pwsh = PowerShell 7; powershell = Windows PowerShell 5.1, the
120+
# default shell on Windows 10/11 and what most `irm | iex` users run.
121+
# 5.1 passes native-command arguments differently (it strips embedded
122+
# double quotes), so the installer must be exercised under both (#8214).
123+
shell: [pwsh, powershell]
116124
steps:
117125
- uses: actions/checkout@v7
118126

@@ -124,7 +132,7 @@ jobs:
124132
run: npm install -g pnpm
125133

126134
- name: Run bin/installer.ps1 against this commit
127-
shell: pwsh
135+
shell: ${{ matrix.shell }}
128136
env:
129137
ETHERPAD_DIR: ${{ runner.temp }}\etherpad-installer-test
130138
ETHERPAD_REPO: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.clone_url || format('{0}/{1}.git', github.server_url, github.repository) }}

0 commit comments

Comments
 (0)