fix(historical-author-cache): address Qodo review on #7769 #7933
JohnMcLearfrontend-tests.yml
on: push
Playwright Chrome
3m 28s
Playwright Firefox
4m 51s
Playwright Chrome with plugins
4m 25s
Playwright Firefox with plugins
4m 58s
Annotations
1 error, 4 warnings, and 4 notices
|
[chromium] › tests/frontend-new/specs/undo_redo_scroll.spec.ts:31:7 › Undo scroll-to-caret (#7007) › Ctrl+Z scrolls viewport up when the caret lands above the view:
src/tests/frontend-new/specs/undo_redo_scroll.spec.ts#L74
1) [chromium] › tests/frontend-new/specs/undo_redo_scroll.spec.ts:31:7 › Undo scroll-to-caret (#7007) › Ctrl+Z scrolls viewport up when the caret lands above the view
Error: expect(received).toBeLessThan(expected)
Expected: < 617
Received: 617
72 | // Pre-fix: scrollAfter ≈ scrollBefore (no scroll).
73 | // Fixed: scrollAfter < scrollBefore (viewport moved up toward the caret).
> 74 | expect(scrollAfter).toBeLessThan(scrollBefore);
| ^
75 | });
76 |
77 | test('Ctrl+Z scrolls viewport down when the caret lands below the view', async function ({page}) {
at /home/runner/work/etherpad/etherpad/src/tests/frontend-new/specs/undo_redo_scroll.spec.ts:74:25
|
|
Playwright Firefox
No files were found with the provided path: src/playwright-report/. No artifacts will be uploaded.
|
|
Playwright Chrome
No files were found with the provided path: src/playwright-report/. No artifacts will be uploaded.
|
|
Playwright Chrome with plugins
No files were found with the provided path: src/playwright-report/. No artifacts will be uploaded.
|
|
Playwright Firefox with plugins
No files were found with the provided path: src/playwright-report/. No artifacts will be uploaded.
|
|
🎭 Playwright Run Summary
1 skipped
209 passed (3.7m)
|
|
🎭 Playwright Run Summary
1 skipped
209 passed (2.5m)
|
|
🎭 Playwright Run Summary
1 flaky
[chromium] › tests/frontend-new/specs/undo_redo_scroll.spec.ts:31:7 › Undo scroll-to-caret (#7007) › Ctrl+Z scrolls viewport up when the caret lands above the view
2 skipped
234 passed (2.9m)
|
|
🎭 Playwright Run Summary
2 skipped
235 passed (3.4m)
|