-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raftLog: decouple log data structure and flow control #142
Comments
@pav-kv can i take this ? |
@Elbehery Sure, give it a try. I got to say that The complexity may vary here depending on how far we go with it. But we can start with simple mechanical decoupling, and revisiting the tests. Also, let's not merge big changes before the release #89 is done. We can prepare the change in parallel though. |
sgtm, please assign me 👍🏽 |
Is this still needed? This looks like a nice task, and I would be happy to work on it. |
+1 |
@pav-kv Please has this issue been resolved. If not, i would like love to work on it |
I don't think it's resolved, feel free to contribute / send PRs. Please note that I'm not active on this repository, you might want to coordinate with maintainers/approvers. |
The raftLog structure currently plays multiple roles. Notably:
unstable
in-memory part, and theStorage
part), and keeps the basic metadata about the log.raft
algorithm.The flow control role is quite distinct from the other roles, and is less fundamental. It should be decoupled. Once decoupling is done,
raftLog
can be isolated in its own package and rigorously tested without assumptions about the flow.Related to #64, though this clean-up has value on its own.
The text was updated successfully, but these errors were encountered: