Skip to content

Commit 929af98

Browse files
committed
source-oracle: use online as default dictionary mode
extract mode is better for long-term consistency since it supports schema changes, but it is really slow. online mode is much faster and it gives users a better first experience. If they hit an issue with schema changes, they can switch to extract mode, and theoretically they can switch back to online mode after the schema changes are captured.
1 parent df0e750 commit 929af98

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

source-oracle/main.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ type advancedConfig struct {
123123
IncrementalSCNRange int `json:"incremental_scn_range,omitempty" jsonschema:"title=Incremental SCN Range,default=50000,description=The SCN range captured at every iteration."`
124124
DiscoverSchemas []string `json:"discover_schemas,omitempty" jsonschema:"title=Discovery Schema Selection,description=If this is specified only tables in the selected schema(s) will be automatically discovered. Omit all entries to discover tables from all schemas."`
125125
NodeID uint32 `json:"node_id,omitempty" jsonschema:"title=Node ID,description=Node ID for the capture. Each node in a replication cluster must have a unique 32-bit ID. The specific value doesn't matter so long as it is unique. If unset or zero the connector will pick a value."`
126-
DictionaryMode string `json:"dictionary_mode,omitempty" jsonschema:"title=Dictionary Mode,description=How should dictionaries be used in Logminer: one of online or extract. When using online mode schema changes to the table may break the capture but resource usage is limited. When using extract mode schema changes are handled gracefully but more resources of your database (including disk) are used by the process. Defaults to extract.,enum=extract,enum=online"`
126+
DictionaryMode string `json:"dictionary_mode,omitempty" jsonschema:"title=Dictionary Mode,description=How should dictionaries be used in Logminer: one of online or extract. When using online mode schema changes to the table may break the capture but resource usage is limited. When using extract mode schema changes are handled gracefully but more resources of your database (including disk) are used by the process. Defaults to online.,enum=extract,enum=online"`
127127
}
128128

129129
// Validate checks that the configuration possesses all required properties.
@@ -188,7 +188,7 @@ func (c *Config) SetDefaults(name string) {
188188
}
189189

190190
if c.Advanced.DictionaryMode == "" {
191-
c.Advanced.DictionaryMode = DictionaryModeExtract
191+
c.Advanced.DictionaryMode = DictionaryModeOnline
192192
}
193193
}
194194

0 commit comments

Comments
 (0)