From 5b3af031c881c37e5e2cf9ebc451bc15bc1f7f47 Mon Sep 17 00:00:00 2001 From: Nikas Praninskas Date: Thu, 30 Apr 2020 11:10:29 +0300 Subject: [PATCH 1/5] Expose lite build without estraverse being bundled --- rollup.config.js | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index b2f36dc..3a1dea4 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -16,18 +16,26 @@ import babel from 'rollup-plugin-babel'; * @param {PlainObject} [config= {}] * @param {boolean} [config.minifying=false] * @param {string} [config.format='umd'] + * @param {boolean} [config.lite=false] * @returns {external:RollupConfig} */ -function getRollupObject ({ minifying, format = 'umd' } = {}) { +function getRollupObject ({ minifying, format = 'umd', lite } = {}) { const nonMinified = { input: 'esquery.js', output: { format, sourcemap: minifying, - file: `dist/esquery${ - format === 'umd' ? '' : `.${format}` - }${minifying ? '.min' : ''}.js`, - name: 'esquery' + file: [ + 'dist/esquery', + lite ? '.lite' : '', + format === 'umd' ? '' : `.${format}`, + minifying ? '.min' : '', + '.js' + ].join(''), + name: 'esquery', + globals: { + estraverse: 'estraverse' + } }, plugins: [ json(), @@ -36,6 +44,9 @@ function getRollupObject ({ minifying, format = 'umd' } = {}) { babel() ] }; + if (lite) { + nonMinified.external = ['estraverse']; + } if (minifying) { nonMinified.plugins.push(terser()); } @@ -46,5 +57,7 @@ export default [ getRollupObject({ minifying: true, format: 'umd' }), getRollupObject({ minifying: false, format: 'umd' }), getRollupObject({ minifying: true, format: 'esm' }), - getRollupObject({ minifying: false, format: 'esm' }) + getRollupObject({ minifying: false, format: 'esm' }), + getRollupObject({ minifying: true, format: 'umd', lite: true }), + getRollupObject({ minifying: false, format: 'umd', lite: true }) ]; From bec85e126e351c44a739ad66e7010f9e89328d00 Mon Sep 17 00:00:00 2001 From: Nikas Praninskas Date: Thu, 30 Apr 2020 16:36:53 +0300 Subject: [PATCH 2/5] Add a lite esm build --- rollup.config.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index 3a1dea4..583aef2 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -56,8 +56,10 @@ function getRollupObject ({ minifying, format = 'umd', lite } = {}) { export default [ getRollupObject({ minifying: true, format: 'umd' }), getRollupObject({ minifying: false, format: 'umd' }), + getRollupObject({ minifying: true, format: 'umd', lite: true }), + getRollupObject({ minifying: false, format: 'umd', lite: true }), getRollupObject({ minifying: true, format: 'esm' }), getRollupObject({ minifying: false, format: 'esm' }), - getRollupObject({ minifying: true, format: 'umd', lite: true }), - getRollupObject({ minifying: false, format: 'umd', lite: true }) + getRollupObject({ minifying: true, format: 'esm', lite: true }), + getRollupObject({ minifying: false, format: 'esm', lite: true }) ]; From 7adec39430fa29904d5bcb2f4184c55a766067a0 Mon Sep 17 00:00:00 2001 From: Nikas Praninskas Date: Mon, 4 May 2020 13:47:30 +0300 Subject: [PATCH 3/5] Revert "Add a lite esm build" This reverts commit bec85e126e351c44a739ad66e7010f9e89328d00. --- rollup.config.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index 583aef2..3a1dea4 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -56,10 +56,8 @@ function getRollupObject ({ minifying, format = 'umd', lite } = {}) { export default [ getRollupObject({ minifying: true, format: 'umd' }), getRollupObject({ minifying: false, format: 'umd' }), - getRollupObject({ minifying: true, format: 'umd', lite: true }), - getRollupObject({ minifying: false, format: 'umd', lite: true }), getRollupObject({ minifying: true, format: 'esm' }), getRollupObject({ minifying: false, format: 'esm' }), - getRollupObject({ minifying: true, format: 'esm', lite: true }), - getRollupObject({ minifying: false, format: 'esm', lite: true }) + getRollupObject({ minifying: true, format: 'umd', lite: true }), + getRollupObject({ minifying: false, format: 'umd', lite: true }) ]; From 005a9bdd3f33d48eb04d31cd65c5fbf2fcbd7da1 Mon Sep 17 00:00:00 2001 From: Nikas Praninskas Date: Mon, 4 May 2020 20:49:46 +0300 Subject: [PATCH 4/5] Use dependencies from package.json rather than hardcoding --- rollup.config.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rollup.config.js b/rollup.config.js index 3a1dea4..f441dd4 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -5,6 +5,7 @@ import commonjs from '@rollup/plugin-commonjs'; import json from '@rollup/plugin-json'; import babel from 'rollup-plugin-babel'; +import packageJson from './package.json'; /** * @external RollupConfig @@ -45,7 +46,7 @@ function getRollupObject ({ minifying, format = 'umd', lite } = {}) { ] }; if (lite) { - nonMinified.external = ['estraverse']; + nonMinified.external = Object.keys(packageJson.dependencies); } if (minifying) { nonMinified.plugins.push(terser()); From 72a9c56c7f2b0015839e66b33d3b82319f1370c5 Mon Sep 17 00:00:00 2001 From: Michael Ficarra Date: Mon, 4 May 2020 13:50:38 -0700 Subject: [PATCH 5/5] Update rollup.config.js --- rollup.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rollup.config.js b/rollup.config.js index f441dd4..563a1bb 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -20,7 +20,7 @@ import packageJson from './package.json'; * @param {boolean} [config.lite=false] * @returns {external:RollupConfig} */ -function getRollupObject ({ minifying, format = 'umd', lite } = {}) { +function getRollupObject ({ minifying = false, format = 'umd', lite = false } = {}) { const nonMinified = { input: 'esquery.js', output: {